camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nicolaferraro <...@git.apache.org>
Subject [GitHub] camel pull request #1607: CAMEL-10650: global sslContextParameters
Date Fri, 07 Apr 2017 17:39:23 GMT
GitHub user nicolaferraro opened a pull request:

    https://github.com/apache/camel/pull/1607

    CAMEL-10650: global sslContextParameters

    Submitting for a review.
    It basically adds global ssl parameters that can be configured using spring-boot properties.
There is no ide autocompletion at the moment, bu I'll add it. A sample configuration is contained
in the tests e.g. of `camel-undertow-starter`.
    
    To create a global ssl config, I needed to take care of:
    - Change each component using SSLContextParameters to lookup the new default if no configuration
is given
    - Not clash with spring xml configuration of SSLContextParameters, so I avoided putting
into the registry an instance of SSLContextParameters, instead I put a GlobalSSLContextParametersSupplier
class.
    - Make sure that taking a default does not change the behaviour of the component: for
components where the presence of a SSLContextParameters in the config turns on the SSL mode,
I've put a flag named "useGlobalSslContextParameters" to disable the feature. For some components,
the default is false (do not use the global config).
    
    For http/tcp components there is no need of such flag since SSL is enabled by other means
(e.g. "https://" in the uri). Some components have their own flag to enable SSL.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nicolaferraro/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1607.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1607
    
----
commit 854774eca5c8caec34fc41bb8d52386ecd581537
Author: Nicola Ferraro <ni.ferraro@gmail.com>
Date:   2017-04-06T12:52:06Z

    CAMEL-10650: adding sslContextParameters to spring-boot configuration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message