camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NickCis <...@git.apache.org>
Subject [GitHub] camel pull request #1526: CAMEL-10966 Salesforce Maven Plugin doesn't escape...
Date Fri, 10 Mar 2017 15:48:38 GMT
GitHub user NickCis opened a pull request:

    https://github.com/apache/camel/pull/1526

    CAMEL-10966 Salesforce Maven Plugin doesn't escape strings when doing the camel-salesforce:generate
phase

    [Jira Ticket](https://issues.apache.org/jira/browse/CAMEL-10966)
    
    Continuing with the previous [PR](https://github.com/apache/camel/pull/1511). 
    
    This PR fixes escaping in `sobject-pojo` file.
    
    In addition, it directly uses _apache lang3 EscapeUtils_ instead of relying in _Velocity
Escape Tools_. This last change is done due to a bug in slash (`/`) escaping of the library.
    
    Some tests were included, i think i coded them in an ugly way, please help me improve
them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NickCis/camel salesforce-maven-plugin-escaping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1526
    
----
commit 512f5372c8c5736f3b56d9f908aea3c05812f21d
Author: Nicolas Cisco <nicolas.cisco@semperti.com>
Date:   2017-03-09T18:53:58Z

    Escaping strings in SObject Pojo

commit 265d774ab93e02def6f25d1e43fb468e35018136
Author: Nicolas Cisco <nicolas.cisco@semperti.com>
Date:   2017-03-09T18:59:07Z

    Removed used use of Velocity Escape Utils, using apache commons lang3 StringEscapeUtils
in order to prevent slash escaping

commit fec2c93c4c046750d6d5f0eebf8d5f60ca3f79bb
Author: Nicolas Cisco <nicolas.cisco@semperti.com>
Date:   2017-03-10T15:40:31Z

    Adding test cases for template generation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message