camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: I've made Service extend from Closeable
Date Fri, 17 Mar 2017 08:09:29 GMT
On Thu, Mar 16, 2017 at 11:51 PM, Zoran Regvart <zoran@regvart.com> wrote:
> Yeah,
> I'm only worried that this would introduce confusion amongst users,
> and once we release a version of Camel with this it's forever there.
>

Yeah we could revert it.

Or what if you add closable on ServiceSupport which they all extend,
would it work with try with resources still, and then you can
implement the close method directly on ServiceSupport which maybe
would not cause Eclipse to show that problem?

If not we can log a ticket about an API change for Camel 3.0. And look
at this then.

> zoran
>
> On Thu, Mar 16, 2017 at 3:13 PM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>> Hi
>>
>> Okay se we do not see this in IDEA - its after all a smarter editor ;)
>>
>> On Wed, Mar 15, 2017 at 10:26 AM, Zoran Regvart <zoran@regvart.com> wrote:
>>> Hi,
>>> for instance in BeanLookupUsingJndiRegistryIssueTest.java:34[1], the
>>> warrning I get in Eclipse is:
>>>
>>> "Resource leak: 'camel' is never closed"
>>>
>>> this is because the resource leak detection code in IDE is looking for
>>> close(), but we have stop()
>>>
>>> zoran
>>>
>>> [1] https://github.com/apache/camel/blob/master/camel-core/src/test/java/org/apache/camel/component/bean/BeanLookupUsingJndiRegistryIssueTest.java#L34
>>>
>>> On Wed, Mar 15, 2017 at 10:01 AM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>>>> Hi
>>>>
>>>> Is there an example you can point we can open in our IDEs to see ?
>>>>
>>>>
>>>> On Wed, Mar 15, 2017 at 9:49 AM, Zoran Regvart <zoran@regvart.com>
wrote:
>>>>> Hi,
>>>>> just giving the discussion on the PR#1537[1], CAMEL-11011[2] more
>>>>> visibility here if anyone would like to comment.
>>>>> The downside I found was that the IDE issues a warning about
>>>>> 'Potential resource leak'. I don't know if this would be reason enough
>>>>> to revert this?
>>>>>
>>>>> zoran
>>>>>
>>>>> [1] https://github.com/apache/camel/pull/1537
>>>>> [2] https://issues.apache.org/jira/browse/CAMEL-11011
>>>>> --
>>>>> Zoran Regvart
>>>>
>>>>
>>>>
>>>> --
>>>> Claus Ibsen
>>>> -----------------
>>>> http://davsclaus.com @davsclaus
>>>> Camel in Action 2: https://www.manning.com/ibsen2
>>>
>>>
>>>
>>> --
>>> Zoran Regvart
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>
>
>
> --
> Zoran Regvart



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

Mime
View raw message