camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zoran Regvart <zo...@regvart.com>
Subject Re: Camel-Salesforce authentication
Date Tue, 07 Feb 2017 09:01:57 GMT
Hi Mabrouk,
thank you for the contribution, I've found two lesser issues: instead
of: `if (foo == null)` I think preferred way is to use
`ObjectHelper.isEmpty`, and the javadoc on `refreshToken` field could
reference `OAuth refresh token` instead of `consumer token`

thanks!

zoran

On Mon, Feb 6, 2017 at 3:52 PM, mabroukb <mabroukb@gmail.com> wrote:
> hello Zoran,
>
> I created the issue under https://issues.apache.org/jira/browse/CAMEL-10779.
> There is alos a PR provided, can you or on of your team member reviez it ?
> (It's viewable under https://github.com/apache/camel/pull/1448 )

-- 
Zoran Regvart

Mime
View raw message