camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nicolaferraro <...@git.apache.org>
Subject [GitHub] camel pull request #1248: CAMEL-10420: Allow custom changes to the pom.xml f...
Date Fri, 04 Nov 2016 11:52:48 GMT
GitHub user nicolaferraro opened a pull request:

    https://github.com/apache/camel/pull/1248

    CAMEL-10420: Allow custom changes to the pom.xml files

    Looking for a review because it's a bit ugly.
    
    The aim is not to get the pom.xml of the starters overwritten at each build, and so be
able to define eg. test dependencies and other stuff.
    
    To do so, I changed the generator to add a *start* and a *end* markers before writing
anything to the pom. Whenever a pom.xml is already present in the starter, the plugin now
loads it and remove anything between the markers, in order to get a clean base pom. The plugin
then redoes the work on top of it.
    
    This way, custom changes are not erased. But maybe there is a cleaner solution to this.
Thoughts?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nicolaferraro/camel CAMEL-10420

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1248
    
----
commit 2e3d5e1f0e011b8493a111f20e67e26db77ef851
Author: Nicola Ferraro <ni.ferraro@gmail.com>
Date:   2016-11-04T11:22:59Z

    CAMEL-10420: Allowing changes to the starter poms

commit 8ba8ca7dfa4eb24bbfbe5a3ac80fb096f6960d00
Author: Nicola Ferraro <ni.ferraro@gmail.com>
Date:   2016-11-04T11:39:21Z

    CAMEL-10420: Regenerating poms

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message