camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YoshikiHigo <...@git.apache.org>
Subject [GitHub] camel pull request #1108: replacing convertTo() with mandatoryConvertTo()
Date Thu, 04 Aug 2016 15:18:35 GMT
GitHub user YoshikiHigo opened a pull request:

    https://github.com/apache/camel/pull/1108

    replacing convertTo() with mandatoryConvertTo()

    We replaced "convertTo()" invocations to "mandatoryConvertTo()" because the same changes
were conducted in the past commits. 
    
    commit ID: b605eb032b080c8c697ea69ceb588e3d4bab9d48
    https://apache.googlesource.com/camel/+/b605eb032b080c8c697ea69ceb588e3d4bab9d48%5E%21/#F1
    
    commit ID: ec1509662bf567e277e7d67b33732660e52d1b6c
    https://apache.googlesource.com/camel/+/ec1509662bf567e277e7d67b33732660e52d1b6c%5E%21/#F1
    
    commit ID: e7487d332d01a86a757c0d89fd6d6eb0a1bbbfcb
    https://apache.googlesource.com/camel/+/e7487d332d01a86a757c0d89fd6d6eb0a1bbbfcb%5E%21/#F1
    
    The change pattern we found is replacing "convertTo(byte[].class, in)"
    invocations with "mandatoryConvertTo(byte[].class, in)" invocations.
    The difference between the two methods seems whether they can return
    null or not.
    https://camel.apache.org/maven/current/camel-core/apidocs/org/apache/camel/TypeConverter.html#mandatoryConvertTo(java.lang.Class,%20org.apache.camel.Exchange,%20java.lang.Object)
    
    --
    Yoshiki, Shinpei, Hideaki, and Mei

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YoshikiHigo/camel bugfix01

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1108
    
----
commit cc4cc74a1c2c06d5065d02094d3b6e76551cf114
Author: Yoshiki Higo <yoshiki.higo@gmail.com>
Date:   2016-08-04T15:07:03Z

    replacing convertTo() with mandatoryConvertTo()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message