Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F412E200B2D for ; Fri, 17 Jun 2016 00:03:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F2BBF160A52; Thu, 16 Jun 2016 22:03:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 493A6160A51 for ; Fri, 17 Jun 2016 00:03:36 +0200 (CEST) Received: (qmail 3681 invoked by uid 500); 16 Jun 2016 22:03:35 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 3670 invoked by uid 99); 16 Jun 2016 22:03:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jun 2016 22:03:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 02A03E009D; Thu, 16 Jun 2016 22:03:35 +0000 (UTC) From: nicolaferraro To: dev@camel.apache.org Reply-To: dev@camel.apache.org Message-ID: Subject: [GitHub] camel pull request #1041: CAMEL-10060: Added fat-jar aware package scan clas... Content-Type: text/plain Date: Thu, 16 Jun 2016 22:03:35 +0000 (UTC) archived-at: Thu, 16 Jun 2016 22:03:37 -0000 GitHub user nicolaferraro opened a pull request: https://github.com/apache/camel/pull/1041 CAMEL-10060: Added fat-jar aware package scan class resolver I've noticed that many modules currently use the package scan class resolver to find specific classes, so CAMEL-10060 is not related to custom converters only. Without a fat-jar-aware package scanner, some users could be unable to run a spring-boot multi-module project or use extension libraries. I extended the default class resolver, to let it search inside nested jars. The new resolver is configured automatically in the camel context when the spring-boot library is imported. I tested it with the offending jar and it works. If this gets merged, I'll add a specific integration test in the new spring-boot suite. Note: I needed to change the modifier of a private method of a core class (`DefaultPackageScanClassResolver`), in order to extend it without rewriting a lot of code. I think we should not care about version compatibility here, but I'm not sure. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nicolaferraro/camel CAMEL-10060 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1041.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1041 ---- commit ac985393343a0192e8fbcf7253e59759f5418cc6 Author: Nicola Ferraro Date: 2016-06-16T21:37:22Z CAMEL-10060: Added fat-jar aware package scan class resolver ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---