camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nicolaferraro <...@git.apache.org>
Subject [GitHub] camel pull request #1041: CAMEL-10060: Added fat-jar aware package scan clas...
Date Thu, 16 Jun 2016 22:03:35 GMT
GitHub user nicolaferraro opened a pull request:

    https://github.com/apache/camel/pull/1041

    CAMEL-10060: Added fat-jar aware package scan class resolver

    I've noticed that many modules currently use the package scan class resolver to find specific
classes, so CAMEL-10060 is not related to custom converters only. Without a fat-jar-aware
package scanner, some users could be unable to run a spring-boot multi-module project or use
extension libraries.
    
    I extended the default class resolver, to let it search inside nested jars. The new resolver
is configured automatically in the camel context when the spring-boot library is imported.
    
    I tested it with the offending jar and it works. If this gets merged, I'll add a specific
integration test in the new spring-boot suite.
    
    Note: I needed to change the modifier of a private method of a core class (`DefaultPackageScanClassResolver`),
in order to extend it without rewriting a lot of code. I think we should not care about version
compatibility here, but I'm not sure.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nicolaferraro/camel CAMEL-10060

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1041
    
----
commit ac985393343a0192e8fbcf7253e59759f5418cc6
Author: Nicola Ferraro <ni.ferraro@gmail.com>
Date:   2016-06-16T21:37:22Z

    CAMEL-10060: Added fat-jar aware package scan class resolver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message