camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PascalSchumacher <...@git.apache.org>
Subject [GitHub] camel pull request: CAMEL-8219: camel-smpp - use jsmpp version 2.2...
Date Thu, 17 Mar 2016 19:20:39 GMT
GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/camel/pull/909

    CAMEL-8219: camel-smpp - use jsmpp version 2.2.3

    Note: Not ready to merge. There are still six failing tests:
    
    >Failed tests:
      SmppBindingTest.createSmppMessageFrom8bitDataCodingDeliverSmShouldNotModifyBody:338
data coding=0xF6; encoding=Big5: actual array was null
    
    >SmppMessageTest.createBodyShouldNotMangle8bitDataCodingShortMessage:130 data coding=0xF6;
encoding=Big5: array lengths differed, expected.length=8 a
    ctual.length=6
    
    >SmppReplaceSmCommandTest.eightBitDataCodingOverridesDefaultAlphabet:274
      Unexpected method call SMPPSession.replaceShortMessage(null, UNKNOWN, UNKNOWN, "1616",
null, null, org.jsmpp.bean.RegisteredDelivery@1, 0, [63, 65,
    66, 0, 63, 127, 67, 63]):
        SMPPSession.replaceShortMessage(isNull(), UNKNOWN, UNKNOWN, "1616", isNull(), isNull(),
org.jsmpp.bean.RegisteredDelivery@1, 0, [-1, 65, 66, 0, -1
    , 127, 67, -1]): expected: 1, actual: 0
    
    >SmppReplaceSmCommandTest.bodyWithGSM8bitDataCodingNotModified:246
      Unexpected method call SMPPSession.replaceShortMessage(null, UNKNOWN, UNKNOWN, "1616",
null, null, org.jsmpp.bean.RegisteredDelivery@1, 0, [63, 65,
    66, 0, 63, 127, 67, 63]):
    
    >SMPPSession.replaceShortMessage(isNull(), UNKNOWN, UNKNOWN, "1616", isNull(), isNull(),
org.jsmpp.bean.RegisteredDelivery@1, 0, [-1, 65, 66, 0, -1
    , 127, 67, -1]): expected: 1, actual: 0
    
    >SmppSubmitMultiCommandTest.bodyWithGSM8bitDataCodingNotModified:336
      Unexpected method call SMPPSession.submitMultiple("CMT", UNKNOWN, UNKNOWN, "1616", [org.jsmpp.bean.Address@bac86b6d],
org.jsmpp.bean.ESMClass@1, 0,
    1, null, null, org.jsmpp.bean.RegisteredDelivery@1, org.jsmpp.bean.ReplaceIfPresentFlag@1,
DataCoding:247, 0, [63, 65, 66, 0, 63, 127, 67, 63]):
        SMPPSession.submitMultiple("CMT", UNKNOWN, UNKNOWN, "1616", [org.jsmpp.bean.Address@bac86b6d],
org.jsmpp.bean.ESMClass@1, 0, 1, isNull(), isNull()
    , org.jsmpp.bean.RegisteredDelivery@1, org.jsmpp.bean.ReplaceIfPresentFlag@1, DataCoding:247,
0, [-1, 65, 66, 0, -1, 127, 67, -1]): expected: 1, actual: 0
    
    >SmppSubmitSmCommandTest.bodyWithGSM8bitDataCodingNotModified:540
      Unexpected method call SMPPSession.submitShortMessage("CMT", UNKNOWN, UNKNOWN, "1616",
UNKNOWN, UNKNOWN, "1717", org.jsmpp.bean.ESMClass@1, 0, 1, nu
    ll, null, org.jsmpp.bean.RegisteredDelivery@1, 0, DataCoding:247, 0, [63, 65, 66, 0, 63,
127, 67, 63]):
        SMPPSession.submitShortMessage("CMT", UNKNOWN, UNKNOWN, "1616", UNKNOWN, UNKNOWN,
"1717", org.jsmpp.bean.ESMClass@1, 0, 1, isNull(), isNull(), org
    .jsmpp.bean.RegisteredDelivery@1, 0, DataCoding:247, 0, [-1, 65, 66, 0, -1, 127, 67, -1]):
expected: 1, actual: 0
    
    Any tips/help with thess would be greatly appreciated. :)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/camel smpp-update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
    
----
commit 2782890ddc2dc878db81e3f22376b095ae78ac56
Author: Pascal Schumacher <pascalschumacher@gmx.net>
Date:   2016-03-17T19:07:31Z

    CAMEL-8219: camel-smpp - use jsmpp version 2.2.3

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message