Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
From: Quinn Stevenson <quinn@pronoia-solutions.com>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_1E4C3594-C991-4A7E-82F1-445141A97EFA"
Message-Id: <49D520D7-5580-4480-8C13-DD3DC73F0566@pronoia-solutions.com>
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: Potential Bug in CamelBlueprintTestSupport
Date: Thu, 14 Jan 2016 08:42:00 -0700
References: <D870E62C-D590-4722-83C3-40C514C1B60B@pronoia-solutions.com>
 <CAAdXmhqZPr7ZR_gemdvQ5ezEaxQ70A4P5yX6gOda=Brf6XxwNg@mail.gmail.com>
 <92F068F3-5964-4446-9F0D-D08980C342EB@pronoia-solutions.com>
 <B0B432B8-E416-4C9F-89E3-19093ACC3044@pronoia-solutions.com>
To: dev@camel.apache.org
In-Reply-To: <B0B432B8-E416-4C9F-89E3-19093ACC3044@pronoia-solutions.com>

--Apple-Mail=_1E4C3594-C991-4A7E-82F1-445141A97EFA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hi Grzegorz -

So is this a bug?  It seems like it is to me, but I don=E2=80=99t want =
to waste anybody=E2=80=99s time with the JIRA if it isn=E2=80=99t and =
I=E2=80=99m just doing something stupid.

Quinn Stevenson


> On Jan 6, 2016, at 3:30 PM, Quinn Stevenson =
<quinn@pronoia-solutions.com> wrote:
>=20
> I just re-ran the test against several versions of Camel and I=E2=80=99v=
e updated the POM in the unit test with the results.
>=20
> To summarize:
> - When the blueprint.xml is in src/test/resources/OSGI-INF/blueprint -
>     these versions work
>       - 2.17-SNAPSHOT
>       - 2.16.1
>       - 2.16.0
>       - 2.15.5
>       - 2.15.4
>     and these versions fail
>       - 2.15.3
>       - 2.15.2
>       - 2.15.1
>       - 2.15.0
>       - 2.14.4
>       - 2.14.3
>       - 2.14.2
>       - 2.14.1
>       - 2.14.0
> - When the blueprint.xml is in src/main/resources/OSGI-INF/blueprint -
>   these versions were tested and all failed
>       - 2.17-SNAPSHOT
>       - 2.16.1
>       - 2.16.0
>       - 2.15.5
>       - 2.15.4
>=20
> Here is the blueprint I=E2=80=99m using
>=20
> <blueprint xmlns=3D"http://www.osgi.org/xmlns/blueprint/v1.0.0 =
<http://www.osgi.org/xmlns/blueprint/v1.0.0>"
>            xmlns:xsi=3D"http://www.w3.org/2001/XMLSchema-instance =
<http://www.w3.org/2001/XMLSchema-instance>"
>            =
xmlns:cm=3D"http://aries.apache.org/blueprint/xmlns/blueprint-cm/v1.1.0 =
<http://aries.apache.org/blueprint/xmlns/blueprint-cm/v1.1.0>"
>            xsi:schemaLocation=3D"
>              =
http://aries.apache.org/blueprint/xmlns/blueprint-cm/v1.1.0 =
<http://aries.apache.org/blueprint/xmlns/blueprint-cm/v1.1.0> =
http://aries.apache.org/schemas/blueprint-cm/blueprint-cm-1.1.0.xsd =
<http://aries.apache.org/schemas/blueprint-cm/blueprint-cm-1.1.0.xsd>
>              http://www.osgi.org/xmlns/blueprint/v1.0.0 =
<http://www.osgi.org/xmlns/blueprint/v1.0.0> =
http://www.osgi.org/xmlns/blueprint/v1.0.0/blueprint.xsd =
<http://www.osgi.org/xmlns/blueprint/v1.0.0/blueprint.xsd>">
>=20
>     <!-- blueprint property placeholders, that will use etc/stuff.cfg =
as the properties file -->
>     <cm:property-placeholder persistent-id=3D"stuff" =
update-strategy=3D"reload">
>         <cm:default-properties>
>             <cm:property name=3D"greeting" value=3D"Hello" />
>             <cm:property name=3D"echo" value=3D"Hey" />
>             <cm:property name=3D"destination" value=3D"mock:original" =
/>
>         </cm:default-properties>
>     </cm:property-placeholder>
>=20
>     <!-- a bean that uses a blueprint property placeholder -->
>     <bean id=3D"myCoolBean" class=3D"org.apache.camel.beans.MyCoolBean">=

>         <property name=3D"say" value=3D"${greeting}"/>
>         <property name=3D"echo" value=3D"${echo}"/>
>     </bean>
>=20
>     <camelContext xmlns=3D"http://camel.apache.org/schema/blueprint =
<http://camel.apache.org/schema/blueprint>">
>=20
>         <route>
>             <from uri=3D"direct:start"/>
>             <bean ref=3D"myCoolBean" method=3D"saySomething"/>
>             <to uri=3D"{{destination}}"/>
>             <bean ref=3D"myCoolBean" method=3D"echoSomething"/>
>             <to uri=3D"{{destination}}"/>
>         </route>
>=20
>     </camelContext>
>=20
> </blueprint>
>=20
> And here is the JUnit test
>=20
> public class ConfigAdminLoadConfigurationFileAndOverrideTest extends =
CamelBlueprintTestSupport {
>=20
>     @Override
>     protected String getBlueprintDescriptor() {
>         // which blueprint XML file to use for this test
>    // If this file is in src/main/resources/OSGI-INF/blueprint, the =
test will fail most of the time
>    // If this file is in src/test/resources/OSGI-INF/blueprint, the =
test passes
>         return "/OSGI-INF/blueprint/configadmin-loadfileoverride.xml";
>     }
>=20
>     @Override
>     protected String[] loadConfigAdminConfigurationFile() {
>         // which .cfg file to use, and the name of the persistence-id
>         return new String[]{"src/test/resources/etc/stuff.cfg", =
"stuff"};
>     }
>=20
>     @Override
>     protected String useOverridePropertiesWithConfigAdmin(Dictionary =
props) throws Exception {
>         // override / add extra properties
>         props.put("destination", "mock:extra");
>=20
>         // return the persistence-id to use
>         return "stuff";
>     }
>=20
>     @Test
>     public void testConfigAdmin() throws Exception {
>         // mock:original comes from =
<cm:default-properties>/<cm:property name=3D"destination" =
value=3D"mock:original" />
>         getMockEndpoint("mock:original").setExpectedMessageCount(0);
>         // mock:result comes from loadConfigAdminConfigurationFile()
>         getMockEndpoint("mock:result").setExpectedMessageCount(0);
>         // mock:extra comes from =
useOverridePropertiesWithConfigAdmin()
>         getMockEndpoint("mock:extra").expectedBodiesReceived("Bye =
World", "Yay Bye WorldYay Bye World");
>=20
>         template.sendBody("direct:start", "World");
>=20
>         assertMockEndpointsSatisfied();
>     }
>=20
> }
>=20
>=20
> Quinn Stevenson
> quinn@pronoia-solutions.com <mailto:quinn@pronoia-solutions.com>
> (801) 244-7758
>=20
>=20
>=20
>> On Jan 6, 2016, at 2:35 PM, Quinn Stevenson =
<quinn@pronoia-solutions.com <mailto:quinn@pronoia-solutions.com>> =
wrote:
>>=20
>> Hi Grzegorz -
>>=20
>> Thank you for the link - I=E2=80=99ve read through it many times - it =
is very very helpful.  =46rom what I understand, this should work - the =
location of the blueprint file shouldn=E2=80=99t effect the way the test =
runs, should it?  Maybe I=E2=80=99m missing something simple.
>>=20
>> It looks like my unit test attachment didn=E2=80=99t come through. =
Sorry - I didn=E2=80=99t think about the mailing list filtering out =
attachments.  You can get to the test here =
https://github.com/hqstevenson/camel-blueprint-test-properties.git =
<https://github.com/hqstevenson/camel-blueprint-test-properties.git>=20
>>=20
>> I've been testing this primary against 2.17-SNAPSHOT, but I=E2=80=99ve =
tested against several versions.  The POM for the unit test has the =
versions listed that I tested, but I was messing with the test a little =
so I=E2=80=99m not sure the list is completely accurate.  I=E2=80=99ll =
verify those and update the POM if needed.
>>=20
>> Quinn Stevenson
>>=20
>>=20
>>> On Jan 6, 2016, at 12:21 PM, Grzegorz Grzybek <gr.grzybek@gmail.com =
<mailto:gr.grzybek@gmail.com>> wrote:
>>>=20
>>> Hello Quinn
>>>=20
>>> What Camel version do you use? I wrote a thorough explanation of
>>> CamelTestBlueprint and the changes we've made to how tests are
>>> performed and synchronized.
>>> Here: =
http://ggrzybek.blogspot.com/2015/12/camel-blueprint-test-support.html =
<http://ggrzybek.blogspot.com/2015/12/camel-blueprint-test-support.html>
>>> You can find there links to JIRA issues describing exactly the same
>>> problems you have with `update-strategy=3D"reload"`.
>>>=20
>>> best regards
>>> Grzegorz Grzybek
>>>=20
>>> 2016-01-06 19:16 GMT+01:00 Quinn Stevenson =
<quinn@pronoia-solutions.com <mailto:quinn@pronoia-solutions.com>>:
>>>> I=E2=80=99ve encountered an issue, but I=E2=80=99m not sure if this =
is a bug or a user error.
>>>>=20
>>>> I=E2=80=99m trying to write some tests using =
CamelBlueprintTestSupport for bundles where the blueprint file is in =
src/main/resources/OSGI-INF/blueprint.  However, I=E2=80=99m getting =
random failures in the test on startup.
>>>>=20
>>>> I=E2=80=99ve narrowed it down to using update-strategy =3D =
=E2=80=9Creload=E2=80=9D and overriding properties in the test.  The =
tests fail (most of the time) when the actual blueprint file is in =
src/main/resources/OSGI-INF/blueprint.  Even when the test doesn=E2=80=99t=
 fail, you=E2=80=99ll see multiple camel contexts get created during the =
test, while the test this is based on from camel-test-blueprint only =
creates two camel contexts.
>>>>=20
>>>> However, if I move the blueprint file to =
src/test/resources/OSGI-INF/blueprint, the test passes.
>>>>=20
>>>> Since I need the blueprint packaged in the bundle in =
OSGI-INF/blueprint, I can=E2=80=99t move the blueprint file to the =
src/test/=E2=80=A6 area.
>>>>=20
>>>> Is there another way I should be testing this sort of thing?
>>>>=20
>>>> I=E2=80=99ve created a unit test based on the =
ConfigAdminLoadConfigurationFileAndOverrideTest from the =
camel-test-blueprint module that demonstrates the issue.
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>> Quinn Stevenson
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>=20
>=20


--Apple-Mail=_1E4C3594-C991-4A7E-82F1-445141A97EFA--