camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lb <lburgazz...@gmail.com>
Subject Re: Camel ApiName Enumeration : object creation optimization
Date Thu, 10 Dec 2015 09:10:58 GMT
Done.

https://issues.apache.org/jira/browse/CAMEL-9408
https://github.com/apache/camel/pull/720

On Wed, Dec 9, 2015 at 5:27 PM, Claus Ibsen <claus.ibsen@gmail.com> wrote:

> Hi Luca
>
> Yay thanks for reporting this. Yeah a JIRA and patch / PR is much welcome
> http://camel.apache.org/contributing
>
> On Wed, Dec 9, 2015 at 2:52 PM, lb <lburgazzoli@gmail.com> wrote:
> > Hi,
> >
> > I've noticed that the code generated by camel-api-component-maven-plugin
> > for ApiName can potentially generate excessive garbage if fromValue is
> > invoked often, this is because:
> >
> > - enum::values() is not cached so it generates a new array for each call
> > - new for style generates an iterator each time
> >
> > So I've create a very simple patch (
> >
> https://github.com/lburgazzoli/apache-camel/commit/c973f5f97ba286c3fa89c0db77f4aad685e05a02
> )
> > that fixes it.
> >
> > If ok I'll open a JIRA and submit a PR.
> >
> >
> > Regards,
> > Luca
>
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message