Return-Path: X-Original-To: apmail-camel-dev-archive@www.apache.org Delivered-To: apmail-camel-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD7D817601 for ; Mon, 22 Jun 2015 07:27:58 +0000 (UTC) Received: (qmail 69511 invoked by uid 500); 22 Jun 2015 07:27:53 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 69466 invoked by uid 500); 22 Jun 2015 07:27:53 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 69453 invoked by uid 99); 22 Jun 2015 07:27:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jun 2015 07:27:53 +0000 X-ASF-Spam-Status: No, hits=0.6 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS,URI_HEX X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of claus.ibsen@gmail.com designates 209.85.213.179 as permitted sender) Received: from [209.85.213.179] (HELO mail-ig0-f179.google.com) (209.85.213.179) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jun 2015 07:25:39 +0000 Received: by igbiq7 with SMTP id iq7so47785064igb.1 for ; Mon, 22 Jun 2015 00:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=09GXVVyClze/JoeTg0Q3wzfWbXFkd+pbKzhsmuD8cBY=; b=jf7SBh911kqSPuSBMic9IXW1mI1lyNbXAg5swWLTEhAyXMlFK/iNQh3VWPENTFYYQY KIR/e84vKWFQc9hrGdXNda1rpIN1HK71g4SbuUYeIP1fbfErXhZmVBffEsC5atrRZtMr Ymae2rMIR0BAz1engLEPz10b0I2VmDmOAGNwfF+U62AxbwUWdOkWAs1UkVynMXZKzQDB p+EQ9pxg3QnQ52CZWOG0mC+WJL/UeRC7m9ftxibz3Kcp61j0gO9tnStzo6qbgch9RKXn Ugb9N4pEaTBgfr37Mb5++Lzt+D1aHrlu+RXHHbmj4eKMc12fhtHMnh2NZXrSoLhFn2/R Vw/Q== X-Received: by 10.43.148.72 with SMTP id kf8mr24921827icc.76.1434958047023; Mon, 22 Jun 2015 00:27:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.120.153 with HTTP; Mon, 22 Jun 2015 00:27:07 -0700 (PDT) In-Reply-To: <1434921499111-5768447.post@n5.nabble.com> References: <1434921499111-5768447.post@n5.nabble.com> From: Claus Ibsen Date: Mon, 22 Jun 2015 09:27:07 +0200 Message-ID: Subject: Re: [HEADS UP] - Compiling components now include validation of you included documentation To: dev Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Hi Babak Thanks for spotting this. I have corrected this, there were duplicated twitter endpoint classes, and it extended a wrong base class. Can you try again with latest code? On Sun, Jun 21, 2015 at 11:18 PM, Babak Vahdat wrote: > Awesome! > > I noticed a typo on the following line (2 x missingDescription instead of > missingSyntax): > > https://github.com/apache/camel/blob/master/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/ErrorDetail.java#L34 > > And currently while building I get the following error on camel-twitter: > > [WARNING] The component: twitter has validation errors > [WARNING] Missing endpoint documentation for the following options: > block > timeout > failIfNoConsumers > > But I failed to find the 3 options above inside it's source. > > Babak > > Claus Ibsen-2 wrote >> Hi >> >> I am putting some final touches on a maven goal that is enabled by >> default as part of building the Camel source code / components. The >> goal validates that you have been a good person and include >> documentation for all the component and endpoint options, include some >> description what the component does, and added a label to categorize >> the component, and so on. >> >> This is possible because every component now includes full out of the >> box documentation for all their options (only salesforce is pending). >> >> The aim is to ensure we document all the options in the future and >> that the docs stay up to date. We have frankly to many components that >> get out of sync with the wiki pages. >> >> Bonus goals is that we will be able to generate parts of the component >> documentation in the future to keep it automatic up to date, and much >> more. >> >> But I just wanted to bring attention to this new validation goal. If >> you omit some documentation etc the goal reports what the error is, >> and which options you need to document. >> >> And for documentation, its just javadoc on the setter (or getter, but >> we favor the setter). >> >> >> PS: I will push the code changes later when I have run a full build of >> the code to ensure they all pass the validation. >> >> >> -- >> Claus Ibsen >> ----------------- >> Red Hat, Inc. >> Email: > >> cibsen@ > >> Twitter: davsclaus >> Blog: http://davsclaus.com >> Author of Camel in Action: http://www.manning.com/ibsen >> hawtio: http://hawt.io/ >> fabric8: http://fabric8.io/ > > > > > > -- > View this message in context: http://camel.465427.n5.nabble.com/HEADS-UP-Compiling-components-now-include-validation-of-you-included-documentation-tp5768400p5768447.html > Sent from the Camel Development mailing list archive at Nabble.com. -- Claus Ibsen ----------------- Red Hat, Inc. Email: cibsen@redhat.com Twitter: davsclaus Blog: http://davsclaus.com Author of Camel in Action: http://www.manning.com/ibsen hawtio: http://hawt.io/ fabric8: http://fabric8.io/