camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From supertypo <...@git.apache.org>
Subject [GitHub] camel pull request: JasyptPropertiesParser: Use interface for encr...
Date Fri, 26 Dec 2014 18:04:50 GMT
GitHub user supertypo opened a pull request:

    https://github.com/apache/camel/pull/361

    JasyptPropertiesParser: Use interface for encryptor, remove getters

    As discussed in https://github.com/apache/camel/pull/357.
    
    Interface StringEncryptor provides encrypt and decrypt methods. Change property encryptor
to interface instead of implementation, which is better for use with OSGI services.
    
    I also propose to remove getters getEncryptor(), getPassword() and getAlgorithm(). As
providing these internals should be unnecessary, and might be considered a security risk.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/supertypo/camel JasyptPropertiesParser-api-change

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #361
    
----
commit 03b7e6cb12bce77267b20e4fe33e1dc49f8fa1db
Author: Marius Thøring <marius.thoring@avinor.no>
Date:   2014-12-18T12:32:14Z

    -Added support for decrypting parts of property values
    -- Example property: some.endpoint=http://somehost?authUsername=username&authPassword=ENC(BjAoLxfpb1h)&token=ENC(ZWbB211g)
    -- Decrypted result: some.endpoint=http://somehost?authUsername=username&authPassword=password&token=sometoken
    -Added possibility to provide a custom encryptor (setEncryptor).
    -- Useful when the encryptor is provided through an osgi service.
    
    Note: The password and algorithm property is ignored when the encryptor property is set.

commit 9f25312dbf9f9f1d6d638c410239d5be413e8f4e
Author: Marius Thøring <mthoring@gmail.com>
Date:   2014-12-24T11:59:10Z

    Improved unit test coverage for JasyptPropertiesParser.

commit b64e920f790c61aed89c6dcb1a2c814f06b16809
Author: Marius Thøring <mthoring@gmail.com>
Date:   2014-12-25T13:18:02Z

    Changes to pass checkstyle checks.

commit d61887f1e9c08d62f73005110eaeac12cc5b1268
Author: Marius Thøring <mthoring@gmail.com>
Date:   2014-12-26T17:02:07Z

    Changed type from StandardPBEStringEncryptor to StringEncryptor interface for getEncryptor()
and setEncryptor().

commit 0a4c4884fe48151b9200fbaf692fae677ab5bbcb
Author: Marius Thøring <mthoring@gmail.com>
Date:   2014-12-26T17:18:48Z

    Removed getter methods for encryptor, password and algorithm.

commit 8dfb7a85389b1b07bcc4e8771fbe6e95cfa19b30
Author: Marius Thøring <mthoring@gmail.com>
Date:   2014-12-26T17:25:37Z

    Moved setter methods to the bottom.

commit 267c66baf59551cefe215ec230458991eb9fff66
Author: Marius Thøring <mthoring@gmail.com>
Date:   2014-12-26T17:53:19Z

    Checkstyle fix. Formatting in javadoc. Moved public methods to the top.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message