Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (athena.apache.org: domain of willem.jiang@gmail.com
 designates 209.85.192.177 as permitted sender)
Date: Tue, 9 Sep 2014 18:27:01 +0800
From: Willem Jiang <willem.jiang@gmail.com>
To: dev@camel.apache.org
Message-ID: <etPan.540ed5f8.74b0dc51.11c@localhost>
In-Reply-To: 
 <CAKxuBdK_-+Dm13KP2GcUagJyktbjjr7PGJ5uSY3AP7bsOCBMkQ@mail.gmail.com>
References: <1525e609b9b240318a7ac652574743c6@git.apache.org>
 <CAGB5yN=gKRqcRSgn1-uJondNkEJ1Y=8YmQskEDV8oDZvaJPCAw@mail.gmail.com>
 <CAKxuBdK_-+Dm13KP2GcUagJyktbjjr7PGJ5uSY3AP7bsOCBMkQ@mail.gmail.com>
Subject: Re: git commit: Fix typeconverter issue
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

=46YI, I just added a unit test and use =46QN to specify the type convert=
er name.

-- =20
Willem Jiang

Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang =20
Weibo: =E5=A7=9C=E5=AE=81willem


On September 9, 2014 at 6:23:29 PM, Jon Anstey (janstey=40gmail.com) wrot=
e:
> Ah spotted a package name used in camel-core so I switched to that. Wil=
l
> double check today which one I need to use.
> On Sep 9, 2014 3:02 AM, =22Claus Ibsen=22 wrote:
> =20
> > Hi
> >
> > In the type converter file you should use the =46QN of the class name=
,
> > so the change was in fact not correct.
> >
> >
> > On Tue, Sep 9, 2014 at 1:07 AM, wrote:
> > > Repository: camel
> > > Updated Branches:
> > > refs/heads/master 17bb643ec -> 033e39885
> > >
> > >
> > > =46ix typeconverter issue
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> > > Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/033e398=
8
> > > Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/033e3988
> > > Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/033e3988
> > >
> > > Branch: refs/heads/master
> > > Commit: 033e39885e476d83da5c26bc1668cb2cefa06781
> > > Parents: 17bb643
> > > Author: Jonathan Anstey =20
> > > Authored: Mon Sep 8 20:37:30 2014 -0230
> > > Committer: Jonathan Anstey =20
> > > Committed: Mon Sep 8 20:37:30 2014 -0230
> > >
> > > -------------------------------------------------------------------=
--- =20
> > > .../component/google/drive/GoogleDrive=46ilesConverter.java =7C 1 +=

> > > .../resources/META-IN=46/services/org/apache/camel/TypeConverter =7C=
 2 +-
> > > .../src/test/resources/test-options.properties =7C 6
> > +++---
> > > 3 files changed, 5 insertions(+), 4 deletions(-)
> > > -------------------------------------------------------------------=
--- =20
> > >
> > >
> > >
> > http://git-wip-us.apache.org/repos/asf/camel/blob/033e3988/components=
/camel-google-drive/src/main/java/org/apache/camel/component/google/drive=
/GoogleDrive=46ilesConverter.java =20
> > > -------------------------------------------------------------------=
--- =20
> > > diff --git
> > a/components/camel-google-drive/src/main/java/org/apache/camel/compon=
ent/google/drive/GoogleDrive=46ilesConverter.java =20
> > b/components/camel-google-drive/src/main/java/org/apache/camel/compon=
ent/google/drive/GoogleDrive=46ilesConverter.java =20
> > > index 3962fdc..7d43705 100644
> > > ---
> > a/components/camel-google-drive/src/main/java/org/apache/camel/compon=
ent/google/drive/GoogleDrive=46ilesConverter.java =20
> > > +++
> > b/components/camel-google-drive/src/main/java/org/apache/camel/compon=
ent/google/drive/GoogleDrive=46ilesConverter.java =20
> > > =40=40 -32,6 +32,7 =40=40 import org.apache.camel.component.file.Ge=
neric=46ile;
> > > import org.slf4j.Logger;
> > > import org.slf4j.Logger=46actory;
> > >
> > > +=40Converter
> > > public final class GoogleDrive=46ilesConverter =7B
> > > private static final Logger LOG =3D
> > Logger=46actory.getLogger(GoogleDrive=46ilesConverter.class);
> > >
> > >
> > >
> > http://git-wip-us.apache.org/repos/asf/camel/blob/033e3988/components=
/camel-google-drive/src/main/resources/META-IN=46/services/org/apache/cam=
el/TypeConverter =20
> > > -------------------------------------------------------------------=
--- =20
> > > diff --git
> > a/components/camel-google-drive/src/main/resources/META-IN=46/service=
s/org/apache/camel/TypeConverter =20
> > b/components/camel-google-drive/src/main/resources/META-IN=46/service=
s/org/apache/camel/TypeConverter =20
> > > index ec2888d..aaf5393 100644
> > > ---
> > a/components/camel-google-drive/src/main/resources/META-IN=46/service=
s/org/apache/camel/TypeConverter =20
> > > +++
> > b/components/camel-google-drive/src/main/resources/META-IN=46/service=
s/org/apache/camel/TypeConverter =20
> > > =40=40 -14,4 +14,4 =40=40
> > > =23 See the License for the specific language governing permissions=
 and
> > > =23 limitations under the License.
> > > =23
> > > -org.apache.camel.component.google.drive.GoogleDrive=46ilesConverte=
r
> > > +org.apache.camel.component.google.drive
> > >
> > >
> > http://git-wip-us.apache.org/repos/asf/camel/blob/033e3988/components=
/camel-google-drive/src/test/resources/test-options.properties =20
> > > -------------------------------------------------------------------=
--- =20
> > > diff --git
> > a/components/camel-google-drive/src/test/resources/test-options.prope=
rties =20
> > b/components/camel-google-drive/src/test/resources/test-options.prope=
rties =20
> > > index 445f90f..a4aabce 100644
> > > ---
> > a/components/camel-google-drive/src/test/resources/test-options.prope=
rties =20
> > > +++
> > b/components/camel-google-drive/src/test/resources/test-options.prope=
rties =20
> > > =40=40 -19,7 +19,7 =40=40
> > > =23=23 Login properties for Google Drive Component
> > > =23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=23=
=23=23=23=23=23=23=23=23=23=23=23=23=23=23
> > > =23=23 Application client id and secret
> > > -clientId=3D
> > > -clientSecret=3D
> > > +clientId=3D
> > 907911893802-6vrkljc27a2rh93c5eo1enu6k77t53dc.apps.googleusercontent.=
com =20
> > > +clientSecret=3DhrpujxUhruuAZa=46tkklc0SCt
> > > applicationName=3Dcamel-google-drive/1.0
> > > -refreshToken=3D
> > > +refreshToken=3D1/tKd7L0nKojQrAQeqcQSWUbXAr7pRJ82L14hpHBlQvVo
> > >
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > Red Hat, Inc.
> > Email: cibsen=40redhat.com
> > Twitter: davsclaus
> > Blog: http://davsclaus.com
> > Author of Camel in Action: http://www.manning.com/ibsen
> > hawtio: http://hawt.io/
> > fabric8: http://fabric8.io/
> >
> =20