camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Willem Jiang <willem.ji...@gmail.com>
Subject Re: git commit: Fix typeconverter issue
Date Tue, 09 Sep 2014 10:27:01 GMT
FYI, I just added a unit test and use FQN to specify the type converter name.

--  
Willem Jiang

Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang  
Weibo: 姜宁willem



On September 9, 2014 at 6:23:29 PM, Jon Anstey (janstey@gmail.com) wrote:
> Ah spotted a package name used in camel-core so I switched to that. Will
> double check today which one I need to use.
> On Sep 9, 2014 3:02 AM, "Claus Ibsen" wrote:
>  
> > Hi
> >
> > In the type converter file you should use the FQN of the class name,
> > so the change was in fact not correct.
> >
> >
> > On Tue, Sep 9, 2014 at 1:07 AM, wrote:
> > > Repository: camel
> > > Updated Branches:
> > > refs/heads/master 17bb643ec -> 033e39885
> > >
> > >
> > > Fix typeconverter issue
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/camel/repo
> > > Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/033e3988
> > > Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/033e3988
> > > Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/033e3988
> > >
> > > Branch: refs/heads/master
> > > Commit: 033e39885e476d83da5c26bc1668cb2cefa06781
> > > Parents: 17bb643
> > > Author: Jonathan Anstey  
> > > Authored: Mon Sep 8 20:37:30 2014 -0230
> > > Committer: Jonathan Anstey  
> > > Committed: Mon Sep 8 20:37:30 2014 -0230
> > >
> > > ----------------------------------------------------------------------  
> > > .../component/google/drive/GoogleDriveFilesConverter.java | 1 +
> > > .../resources/META-INF/services/org/apache/camel/TypeConverter | 2 +-
> > > .../src/test/resources/test-options.properties | 6
> > +++---
> > > 3 files changed, 5 insertions(+), 4 deletions(-)
> > > ----------------------------------------------------------------------  
> > >
> > >
> > >
> > http://git-wip-us.apache.org/repos/asf/camel/blob/033e3988/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/GoogleDriveFilesConverter.java
 
> > > ----------------------------------------------------------------------  
> > > diff --git
> > a/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/GoogleDriveFilesConverter.java
 
> > b/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/GoogleDriveFilesConverter.java
 
> > > index 3962fdc..7d43705 100644
> > > ---
> > a/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/GoogleDriveFilesConverter.java
 
> > > +++
> > b/components/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/GoogleDriveFilesConverter.java
 
> > > @@ -32,6 +32,7 @@ import org.apache.camel.component.file.GenericFile;
> > > import org.slf4j.Logger;
> > > import org.slf4j.LoggerFactory;
> > >
> > > +@Converter
> > > public final class GoogleDriveFilesConverter {
> > > private static final Logger LOG =
> > LoggerFactory.getLogger(GoogleDriveFilesConverter.class);
> > >
> > >
> > >
> > http://git-wip-us.apache.org/repos/asf/camel/blob/033e3988/components/camel-google-drive/src/main/resources/META-INF/services/org/apache/camel/TypeConverter
 
> > > ----------------------------------------------------------------------  
> > > diff --git
> > a/components/camel-google-drive/src/main/resources/META-INF/services/org/apache/camel/TypeConverter
 
> > b/components/camel-google-drive/src/main/resources/META-INF/services/org/apache/camel/TypeConverter
 
> > > index ec2888d..aaf5393 100644
> > > ---
> > a/components/camel-google-drive/src/main/resources/META-INF/services/org/apache/camel/TypeConverter
 
> > > +++
> > b/components/camel-google-drive/src/main/resources/META-INF/services/org/apache/camel/TypeConverter
 
> > > @@ -14,4 +14,4 @@
> > > # See the License for the specific language governing permissions and
> > > # limitations under the License.
> > > #
> > > -org.apache.camel.component.google.drive.GoogleDriveFilesConverter
> > > +org.apache.camel.component.google.drive
> > >
> > >
> > http://git-wip-us.apache.org/repos/asf/camel/blob/033e3988/components/camel-google-drive/src/test/resources/test-options.properties
 
> > > ----------------------------------------------------------------------  
> > > diff --git
> > a/components/camel-google-drive/src/test/resources/test-options.properties  
> > b/components/camel-google-drive/src/test/resources/test-options.properties  
> > > index 445f90f..a4aabce 100644
> > > ---
> > a/components/camel-google-drive/src/test/resources/test-options.properties  
> > > +++
> > b/components/camel-google-drive/src/test/resources/test-options.properties  
> > > @@ -19,7 +19,7 @@
> > > ## Login properties for Google Drive Component
> > > #####################################
> > > ## Application client id and secret
> > > -clientId=
> > > -clientSecret=
> > > +clientId=
> > 907911893802-6vrkljc27a2rh93c5eo1enu6k77t53dc.apps.googleusercontent.com  
> > > +clientSecret=hrpujxUhruuAZaFtkklc0SCt
> > > applicationName=camel-google-drive/1.0
> > > -refreshToken=
> > > +refreshToken=1/tKd7L0nKojQrAQeqcQSWUbXAr7pRJ82L14hpHBlQvVo
> > >
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > Red Hat, Inc.
> > Email: cibsen@redhat.com
> > Twitter: davsclaus
> > Blog: http://davsclaus.com
> > Author of Camel in Action: http://www.manning.com/ibsen
> > hawtio: http://hawt.io/
> > fabric8: http://fabric8.io/
> >
>  


Mime
View raw message