camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aki Yoshida <elak...@gmail.com>
Subject Re: checkstyle
Date Wed, 28 May 2014 14:20:08 GMT
2014-05-28 14:38 GMT+02:00 Matt Sicker <boards@gmail.com>:
> Doesn't the checkstyle plugin add a bit of time to the build? I can see why
> it's not default!
>

It adds more processing but not building with the check on the jenkins
also leaves those violation unnoticed until someone runs the check
locally.

The confusion for me was that cxf and camel have similar profile
options but have a different default behavior.
I thought running "mvn clean install" in camel was also running the
check as in cxf but my assumption was wrong.

Now I know it, so I can adjust to it. But personal I think, …. Well I
stop continuing, as Willem already said there was a discussion before
but there was no agreement.

regards, aki


>
> On 28 May 2014 06:54, Willem Jiang <willem.jiang@gmail.com> wrote:
>
>> Current the checkstyle verification only run when we do the release.
>>
>> We had some argument about enable the -Psourcecheck by default, but we
>> didn’t have the agreement with that.
>>
>> If you are using eclipse, the check style plugin can work very well
>> without running any mvn command :)
>>
>> --
>> Willem Jiang
>>
>> Red Hat, Inc.
>> Web: http://www.redhat.com
>> Blog: http://willemjiang.blogspot.com (English)
>> http://jnn.iteye.com (Chinese)
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>>
>>
>> On May 28, 2014 at 7:09:24 PM, Aki Yoshida (elakito@gmail.com) wrote:
>> > Hi,
>> > I saw Willem fixing some of my checkstyle violation (Thanks Willem)
>> > and realized belately that the checkstyle is not active by default in
>> > camel when doing mvn clean install.
>> >
>> > I thought that the checkstyle was enabled as in cxf by default.
>> >
>> > When I ran mvn -Psourcecheck, I saw some additional checkstyle
>> > violation from my yesterday's commit. I'll fix these now.
>> >
>> > But I wanted to ask if this default deactivation of stylecheck
>> > intended? I personally think it would be better to have the stylecheck
>> > activated for the default install.
>> >
>> > I see some other people also committing violating code. So at least,
>> > this current default build behavior is not known to everyone and I
>> > thought I should bring it up.
>> >
>> > regards, aki
>> >
>>
>>
>
>
> --
> Matt Sicker <boards@gmail.com>

Mime
View raw message