Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <5303622E.8030907@pocock.pro>
Date: Tue, 18 Feb 2014 14:37:50 +0100
From: Daniel Pocock <daniel@pocock.pro>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20131103 Icedove/17.0.10
MIME-Version: 1.0
To: dev@camel.apache.org
Subject: camel-smpp UCS-2 issues
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit


I've observed some oddities sending messages to SMPP that require UCS-2
(16 bit / Unicode) encoding

To make it work, I have to explicitly set:
   alphabet=-1   in the endpoint config
   CamelSmppDataCoding=8   in the exchange headers

and leave other headers and config settings empty/default

Automatic detection of encoding doesn't seem to work, so I have to scan
each message myself and then make those settings when necessary on a
per-message basis.

Given alphabet=-1 in the endpoint config, I also have to explicitly set
CamelSmppAlphabet= ALPHA_DEFAULT for those messages that don't require
UCS-2 treatment

I made a quick review of the code and various things caught my eye:

- the header Exchange.CHARSET_NAME is never checked, it could be more
useful than the "encoding" param in the endpoint config perhaps?

- in SmppSmCommand:

    why does determineCharset() only return UCS2_ENCODING for
UNKNOWN_ALPHABET and not for ALPHA_UCS2?

    why does determineAlphabet() only use the charset configured in the
endpoint?  This seems like a good place to use Exchange.CHARSET_NAME