camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: camel pull request: Provide access to the shutdown task Future in order to ...
Date Tue, 04 Feb 2014 16:41:24 GMT
Polishing your patch as the timeout logic should only happen if a
timeout exception was thrown, as the original code.

Will commit the revised code in a bit. Is there a JIRA ticket?

On Mon, Feb 3, 2014 at 3:52 PM, Antoine DESSAIGNE
<antoine.dessaigne@gmail.com> wrote:
> Hi,
>
> Do you have any concerns or suggestions about these changes ? Right now,
> I've copy/pasted the DefaultShutdownStrategy and added those changes on
> order to make it work (and it's working nicely).
>
> Also, if you don't like this public getter, we can also make it protected.
>
> Thanks for the feedback.
>
> Antoine
>
>
> 2014-01-23 adessaigne <git@git.apache.org>:
>
>> GitHub user adessaigne opened a pull request:
>>
>>     https://github.com/apache/camel/pull/90
>>
>>     Provide access to the shutdown task Future in order to have more
>> control over it
>>
>>     I'm submitting this patch in order to have a greater control over the
>> shutdown task.
>>     It's very useful when integrating Camel in another product. Therefore
>> you can have a user interface for controlling the life-cycle of a context.
>> The user can start or stop a context and if it takes too much time to stop
>> he can force it by calling getCurrentShutdownFuture().cancel(true)
>>
>> You can merge this pull request into a Git repository by running:
>>
>>     $ git pull https://github.com/adessaigne/camel master
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>>     https://github.com/apache/camel/pull/90.patch
>>
>> ----
>> commit 65dc45d9ac0cfd5ed7f2567d93f59b97885274dc
>> Author: Antoine DESSAIGNE <antoine.dessaigne@gmail.com>
>> Date:   2014-01-23T11:16:02Z
>>
>>     Provide access to the shutdown task Future in order to have more
>> control over it
>>
>> ----
>>
>>



-- 
Claus Ibsen
-----------------
Red Hat, Inc.
Email: cibsen@redhat.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
Make your Camel applications look hawt, try: http://hawt.io

Mime
View raw message