camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: git commit: Upgrade to leveldbjni 1.8
Date Sat, 19 Oct 2013 07:54:58 GMT
Hi

The old 1.7 version is actually wrong in its pom.xml file. If you take
a note you can see the native drivers are the older 1.5 version which
is totally wrong.

org.fusesource.leveldbjni:leveldbjni-linux32:jar:1.5:compile

The intent is also these native drivers has scope provided. So you as
an end user can decide if you want to use a native driver or not. If
you want to do that, you add a dependency on the choice - eg linux32 /
64 / windows32 etc.

There is a built-in java driver in the -all JAR which is used by
default. This is also the most hardened driver.

So before we have a worse situation where people would need to use
<exclusion> in maven to remove the wrong drivers with older versions
etc. If they use Maven.

This is now fixed in 1.8, as well another bug. But people can check
the commit logs of leveldbjndi - it is a github project
https://github.com/fusesource/leveldbjni





On Sat, Oct 19, 2013 at 2:25 AM, Christian Müller
<christian.mueller@gmail.com> wrote:
> I'm sure you know the project much better than me, but if you have a look
> at the dependency tree for camel-leveldb 2.12.1:
>
> [INFO] org.apache.camel:camel-leveldb:bundle:2.12.1
> ...
> [INFO] +- org.fusesource.leveldbjni:leveldbjni-all:jar:1.7:compile
> [INFO] |  +- org.fusesource.leveldbjni:leveldbjni-osx:jar:1.5:compile
> [INFO] |  +- org.fusesource.leveldbjni:leveldbjni-linux32:jar:1.5:compile
> [INFO] |  +- org.fusesource.leveldbjni:leveldbjni-linux64:jar:1.5:compile
> [INFO] |  +- org.fusesource.leveldbjni:leveldbjni-win32:jar:1.5:compile
> [INFO] |  \- org.fusesource.leveldbjni:leveldbjni-win64:jar:1.5:compile
> [INFO] +- org.fusesource.leveldbjni:leveldbjni:jar:1.7:compile
> [INFO] |  +- org.fusesource.hawtjni:hawtjni-runtime:jar:1.8:compile
> [INFO] |  \- org.iq80.leveldb:leveldb-api:jar:0.5:compile
> [INFO] +- org.fusesource.hawtbuf:hawtbuf:jar:1.9:compile
>
> and camel-leveldb 2.12.2-SNAPSHOT:
>
> [INFO] org.apache.camel:camel-leveldb:bundle:2.12.2-SNAPSHOT
> ...
> [INFO] +- org.fusesource.leveldbjni:leveldbjni-all:jar:1.8:compile
> [INFO] +- org.fusesource.leveldbjni:leveldbjni:jar:1.8:compile
> [INFO] |  +- org.fusesource.hawtjni:hawtjni-runtime:jar:1.9:compile
> [INFO] |  \- org.iq80.leveldb:leveldb-api:jar:0.6:compile
> [INFO] +- org.fusesource.hawtbuf:hawtbuf:jar:1.9:compile
>
> there is a bigger difference than I would expect in a bug fix release. Are
> all the leveldbjni-someOS JAR's obsolete? Or contains leveldbjni-all all
> this JAR's now?
>
> Best,
>
> Christian
> -----------------
>
> Software Integration Specialist
>
> Apache Member
> V.P. Apache Camel | Apache Camel PMC Member | Apache Camel committer
> Apache Incubator PMC Member
>
> https://www.linkedin.com/pub/christian-mueller/11/551/642
>
>
> On Fri, Oct 18, 2013 at 2:44 PM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>
>> Not every project has 3 digits for their versions. Some have only 2.
>> And these projects may do bug fix releases where upgrading is
>> safe/compatible.
>>
>> So when a 2 digit project does a release, then it can be a bug fix
>> release like leveldb 1.7 to 1.8 is.
>>
>> For example you can try
>> http://vdiff.notsoclever.cc/
>>
>> And see the diff in Camel 2.10.0 and 2.10.7 etc.
>>
>>
>>
>> On Fri, Oct 18, 2013 at 1:39 PM, Christian Müller
>> <christian.mueller@gmail.com> wrote:
>> > Is this minor dependency upgrade in a Camel micro release also because of
>> > an issue with Leveldb in Camel 2.12.1? Do we have an issue for this?
>> >
>> > Best,
>> >
>> > Christian
>> > -----------------
>> >
>> > Software Integration Specialist
>> >
>> > Apache Member
>> > V.P. Apache Camel | Apache Camel PMC Member | Apache Camel committer
>> > Apache Incubator PMC Member
>> >
>> > https://www.linkedin.com/pub/christian-mueller/11/551/642
>> >
>> >
>> > On Fri, Oct 18, 2013 at 11:10 AM, <davsclaus@apache.org> wrote:
>> >
>> >> Updated Branches:
>> >>   refs/heads/camel-2.12.x 2b3704f97 -> b220ce070
>> >>
>> >>
>> >> Upgrade to leveldbjni 1.8
>> >>
>> >>
>> >> Project: http://git-wip-us.apache.org/repos/asf/camel/repo
>> >> Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/b220ce07
>> >> Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/b220ce07
>> >> Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/b220ce07
>> >>
>> >> Branch: refs/heads/camel-2.12.x
>> >> Commit: b220ce0702ed55496d394e6e337a36beb45f7a9d
>> >> Parents: 2b3704f
>> >> Author: Claus Ibsen <davsclaus@apache.org>
>> >> Authored: Fri Oct 18 09:47:41 2013 +0200
>> >> Committer: Claus Ibsen <davsclaus@apache.org>
>> >> Committed: Fri Oct 18 11:10:51 2013 +0200
>> >>
>> >> ----------------------------------------------------------------------
>> >>  parent/pom.xml | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >> ----------------------------------------------------------------------
>> >>
>> >>
>> >>
>> http://git-wip-us.apache.org/repos/asf/camel/blob/b220ce07/parent/pom.xml
>> >> ----------------------------------------------------------------------
>> >> diff --git a/parent/pom.xml b/parent/pom.xml
>> >> index f1bc66c..b7b0fae 100644
>> >> --- a/parent/pom.xml
>> >> +++ b/parent/pom.xml
>> >> @@ -248,7 +248,7 @@
>> >>      <karaf-version>2.3.3</karaf-version>
>> >>      <krati-version>0.4.9</krati-version>
>> >>      <kxml2-bundle-version>2.3.0_2</kxml2-bundle-version>
>> >> -    <leveldbjni-version>1.7</leveldbjni-version>
>> >> +    <leveldbjni-version>1.8</leveldbjni-version>
>> >>      <log4j-version>1.2.17</log4j-version>
>> >>      <!-- we await upgrade for lucene 4.x to sync -->
>> >>      <lucene-bundle-version>3.6.0_1</lucene-bundle-version>
>> >>
>> >>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> Red Hat, Inc.
>> Email: cibsen@redhat.com
>> Twitter: davsclaus
>> Blog: http://davsclaus.com
>> Author of Camel in Action: http://www.manning.com/ibsen
>>



-- 
Claus Ibsen
-----------------
Red Hat, Inc.
Email: cibsen@redhat.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen

Mime
View raw message