camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Babak Vahdat <babak.vah...@swissonline.ch>
Subject Re: [DISCUSS] - Apache Camel 2.11.1 release
Date Mon, 08 Jul 2013 19:56:58 GMT
Hi

To my understanding this is "worked as designed" and we should close
CAMEL-6414 as "Not a Problem" because the unary operator String "--" is part
of the language itself so that Camel simple parser tries to decrement isA by
1 which apparently fails as the conversion of isA to a java.lang.Number
fails (see
https://github.com/apache/camel/blob/master/camel-core/src/main/java/org/apache/camel/language/simple/ast/UnaryExpression.java#L114).
For example if you would change the ignored test you've added as following
then it would run green:

…
        SimpleExpressionParser parser = new SimpleExpressionParser("THE MSG
ID ${header.JMSMessageID}3--", true);
…
        assertEquals("THE MSG ID JMSMessageID-1232", exp.evaluate(exchange,
String.class));

As you see we just decremented 3 by 1 which results to 2. In this case we
decremented a literal but as well you can also decrement a function, see
SimpleDecHeaderTest for an example of this.

I'm sure Claus can correct me if I'm wrong here :-)

Babak


Christian Mueller wrote
> Hadrian, go ahead for doing this release...
> 
> I reported one of the issues and added an unit test (ignored at present),
> but I didn't assigned the ticket to myself. I think we have other
> committers who could fix this with less effort than me...
> 
> Best,
> Christian
> -----------------
> 
> Software Integration Specialist
> 
> Apache Camel committer: https://camel.apache.org/team
> V.P. Apache Camel: https://www.apache.org/foundation/
> Apache Member: https://www.apache.org/foundation/members.html
> 
> https://www.linkedin.com/pub/christian-mueller/11/551/642
> 
> 
> On Mon, Jul 8, 2013 at 5:24 PM, Hadrian Zbarcea &lt;

> hzbarcea@

> &gt; wrote:
> 
>> I could do it too, got back from vacation.
>>
>> One of the issues is yours Christian, I will look into it after finishing
>> this build. The other one is just doc, I think.
>>
>> Running a full test now, all good so far (almost forgot how long it takes
>> :( ).
>>
>> Hadrian
>>
>>
>> On 07/08/2013 10:59 AM, Christian Müller wrote:
>>
>>> I can do it. What's with the two outstanding issues? Could you have a
>>> look
>>> and fix them or postpone them to 2.11.2?
>>>
>>> Best,
>>> Christian
>>>
>>> Sent from a mobile device
>>> Am 08.07.2013 14:58 schrieb "Claus Ibsen" &lt;

> claus.ibsen@

> &gt;:
>>>
>>>  Hi
>>>>
>>>> Christian do you have time to work on the 2.11.1 release? Would be
>>>> great to get this out as well.
>>>>
>>>>
>>>> On Mon, Jul 1, 2013 at 12:09 AM, Christian Müller
>>>> &lt;

> christian.mueller@

> &gt; wrote:
>>>>
>>>>> Thanks Hadrian for the offer. If we are not able to start the release
>>>>>
>>>> this
>>>>
>>>>> week, I'm happy to take this over to you :-).
>>>>>
>>>>> I updated the maven release plugin configuration for the 2.11.x
>>>>>
>>>> maintenance
>>>>
>>>>> branch to use the Git repo and merged Dan's change to only generate
>>>>> the
>>>>> HTML manual. I tested it and it works fine.
>>>>>
>>>>> Claus and me pushed a few issues to Camel 2.11.2 and now, we only have
>>>>> 9
>>>>> outstanding issues scheduled for Camel 2.11.1.
>>>>> 2 of these issues are classified as bug and should be fixed.
>>>>> 2 other issues addressing missing documentation for new components
>>>>> (ical
>>>>> and scala-extraz).
>>>>>
>>>>> All other issues are 'nice to have' in Camel 2.11.1, but not
>>>>> 'required',
>>>>>
>>>> in
>>>>
>>>>> my opinion.
>>>>>
>>>>> Best,
>>>>> Christian
>>>>> -----------------
>>>>>
>>>>> Software Integration Specialist
>>>>>
>>>>> Apache Camel committer: https://camel.apache.org/team
>>>>> V.P. Apache Camel:
>>>>> https://www.apache.org/**foundation/&lt;https://www.apache.org/foundation/&gt;
>>>>> Apache Member:
>>>>> https://www.apache.org/**foundation/members.html&lt;https://www.apache.org/foundation/members.html&gt;
>>>>>
>>>>> https://www.linkedin.com/pub/**christian-mueller/11/551/642&lt;https://www.linkedin.com/pub/christian-mueller/11/551/642&gt;
>>>>>
>>>>>
>>>>> On Fri, Jun 28, 2013 at 12:06 AM, Hadrian Zbarcea &lt;

> hzbarcea@

> &gt;>>> wrote:
>>>>>
>>>>>  Hi Christian,
>>>>>>
>>>>>> Next week I'll be in vacation, but I can do the 2.11.1 after I come
>>>>>>
>>>>> back.
>>>>
>>>>> It should be ok, I assume the 22 issues will not be all resolved next
>>>>>>
>>>>> week.
>>>>
>>>>>
>>>>>> Cheers,
>>>>>> Hadrian
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 06/27/2013 05:02 PM, Christian Müller wrote:
>>>>>>
>>>>>>  We agreed to not build the PDF manual starting with Camel 2.12.0.
We
>>>>>>>
>>>>>> still
>>>>
>>>>> have to discuss whether the HTML manual should still created or not.
>>>>>>> However, because we only publish the HTML/PDF manual for major/minor
>>>>>>> releases, it's not important for Camel 2.11.1.
>>>>>>>
>>>>>>> We have 22 unresolved issues assigned to Camel 2.11.1 [1]. Could
>>>>>>>
>>>>>> everybody
>>>>
>>>>> please have a look and mention the issues which should be included in
>>>>>>>
>>>>>> this
>>>>
>>>>> release. I will move all others to 2.11.2, probably at the weekend...
>>>>>>>
>>>>>>> And I could do the release or support the release manager, if
>>>>>>> someone
>>>>>>>
>>>>>> else
>>>>
>>>>> would like to do it.
>>>>>>>
>>>>>>> [1]
>>>>>>> https://issues.apache.org/****jira/issues/?jql=project%20%**
>>>>>>> 3D%20CAMEL%20AND%20resolution%****20%3D%20Unresolved%20AND%**
>>>>>>> 20fixVersion%20%3D%20%222.11.****1%22<
>>>>>>>
>>>>>> https://issues.apache.org/**jira/issues/?jql=project%20%**
>>>> 3D%20CAMEL%20AND%20resolution%**20%3D%20Unresolved%20AND%**
>>>> 20fixVersion%20%3D%20%222.11.**1%22&lt;https://issues.apache.org/jira/issues/?jql=project%20%3D%20CAMEL%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%20%222.11.1%22&gt;
>>>>
>>>>>
>>>>>
>>>>>>> Best,
>>>>>>> Christian
>>>>>>> -----------------
>>>>>>>
>>>>>>> Software Integration Specialist
>>>>>>>
>>>>>>> Apache Camel committer: https://camel.apache.org/team
>>>>>>> V.P. Apache Camel:
>>>>>>> https://www.apache.org/****foundation/&lt;https://www.apache.org/**foundation/&gt;
>>>>>>> <
>>>>>>>
>>>>>> https://www.apache.org/**foundation/&lt;https://www.apache.org/foundation/&gt;
>>>> >
>>>>
>>>>> Apache Member:
>>>>> https://www.apache.org/****foundation/members.html&lt;https://www.apache.org/**foundation/members.html&gt;
>>>>>>> <
>>>>>>>
>>>>>> https://www.apache.org/**foundation/members.html&lt;https://www.apache.org/foundation/members.html&gt;
>>>> >
>>>>
>>>>>
>>>>>>> https://www.linkedin.com/pub/****christian-mueller/11/551/642&lt;https://www.linkedin.com/pub/**christian-mueller/11/551/642&gt;
>>>>>>> <
>>>>>>>
>>>>>> https://www.linkedin.com/pub/**christian-mueller/11/551/642&lt;https://www.linkedin.com/pub/christian-mueller/11/551/642&gt;
>>>> >
>>>>
>>>>>
>>>>>>>
>>>>>>> On Thu, Jun 27, 2013 at 3:21 PM, Daniel Kulp &lt;

> dkulp@

> &gt;
>>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>  On Jun 27, 2013, at 6:04 AM, Claus Ibsen &lt;

> claus.ibsen@

> &gt;
>>>>>>>>
>>>>>>> wrote:
>>>>
>>>>>
>>>>>>>>   Hi
>>>>>>>>
>>>>>>>>>
>>>>>>>>> We recently released the 2.10.5 release after our git
migration.
>>>>>>>>> It would be great if we could start working on a 2.11.1
release as
>>>>>>>>>
>>>>>>>> well.
>>>>
>>>>>
>>>>>>>>>
>>>>>>>> I certainly support the idea of a 2.11.1 release, but we
*DO* need
>>>>>>>> to
>>>>>>>> figure out what we want to do with the PDF manual first.
  We can
>>>>>>>> no
>>>>>>>> longer
>>>>>>>> produce a usable manual.
>>>>>>>>
>>>>>>>> Dan
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Claus Ibsen
>>>>>>>>> -----------------
>>>>>>>>> www.camelone.org: The open source integration conference.
>>>>>>>>>
>>>>>>>>> Red Hat, Inc.
>>>>>>>>> FuseSource is now part of Red Hat
>>>>>>>>> Email: 

> cibsen@

>>>>>>>>> Web: http://fusesource.com
>>>>>>>>> Twitter: davsclaus
>>>>>>>>> Blog: http://davsclaus.com
>>>>>>>>> Author of Camel in Action: http://www.manning.com/ibsen
>>>>>>>>>
>>>>>>>>>
>>>>>>>> --
>>>>>>>> Daniel Kulp
>>>>>>>> 

> dkulp@

>  - http://dankulp.com/blog
>>>>>>>> Talend Community Coder - http://coders.talend.com
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>
>>>>
>>>> --
>>>> Claus Ibsen
>>>> -----------------
>>>> Red Hat, Inc.
>>>> Email: 

> cibsen@

>>>> Twitter: davsclaus
>>>> Blog: http://davsclaus.com
>>>> Author of Camel in Action: http://www.manning.com/ibsen
>>>>
>>>>
>>>





--
View this message in context: http://camel.465427.n5.nabble.com/DISCUSS-Apache-Camel-2-11-1-release-tp5734891p5735309.html
Sent from the Camel Development mailing list archive at Nabble.com.

Mime
View raw message