camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Babak Vahdat <babak.vah...@swissonline.ch>
Subject Re: Upgrade Spring 3.1.4.RELEASE -> 3.2.2.RELEASE
Date Wed, 15 May 2013 19:04:11 GMT
Hi

Just realized the stuff I've committed today morning would break the Spring
3.1.x support in Camel 2.12.0. The changes are REALLY trivial and are only
for the sake of code simplicity, that's the code like:

   AbstractApplicationContext applicationContext = …
   ...
   if (applicationContext != null) { 
         applicationContext.destroy();
   }

Has become "the one-liner":

   IOHelper.close(applicationContext);

As IOHelper can handle null values and also the destroy() method Impl is
simply a single call to the close() method . This however would only work in
Spring 3.2.x where "AbstractApplicationContext implements java.io.Closeable"
but NOT in Spring 3.1.x where users would probably get NoSuchMethodError and
what not if they have Spring 3.1.x on their class path.

I assume I should revert this commit right?

Babak


Claus Ibsen-2 wrote
> Hi
> 
> Yeah I think it would be good to upgrade to Spring 3.2.x for Camel 2.12.
> Certainly if Karaf / SMX will support that version as well.
> 
> On Sun, May 12, 2013 at 11:45 PM, Christian Müller
> &lt;

> christian.mueller@

> &gt; wrote:
>> I'm wondering whether we should use Spring 3.2.2.RELEASE by default for
>> Camel 2.12.x.
>> This version is stable and by still supporting Spring 3.1.x (with a
>> separate CI build), we can make sure Camel 2.12.x is working with Karaf
>> 2.3.1.
>> Starting with Karaf 2.3.2, Karaf comes with a Spring 3.2 feature [1].
>> Karaf
>> 2.3.2 is expected for  the next two/three weeks [2].
>>
>> What do you think?
>>
>> [1] https://issues.apache.org/jira/browse/KARAF-2062
>> [2]
>> http://karaf.922171.n3.nabble.com/DISCUSSION-Apache-Karaf-2-3-2-and-3-0-0-RC2-in-two-weeks-time-td4028632.html
>>
>> Best,
>> Christian
> 
> 
> 
> -- 
> Claus Ibsen
> -----------------
> www.camelone.org: The open source integration conference.
> 
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: 

> cibsen@

> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen





--
View this message in context: http://camel.465427.n5.nabble.com/Upgrade-Spring-3-1-4-RELEASE-3-2-2-RELEASE-tp5732377p5732631.html
Sent from the Camel Development mailing list archive at Nabble.com.

Mime
View raw message