camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gredler" <dgred...@dhlglobalmail.com>
Subject RE: Support for zip (de)compression
Date Tue, 12 Feb 2013 19:47:51 GMT
Hi guys,

I've uploaded an updated patch. Let me know if there's anything else
that needs changing.

Take care,

Daniel


-----Original Message-----
From: Daniel Gredler [mailto:dgredler@dhlglobalmail.com] 
Sent: Tuesday, February 12, 2013 12:13 PM
To: dev@camel.apache.org
Subject: RE: Support for zip (de)compression

Hi Henryk, Claus,

Cool, thanks for the feedback! I'll update the patch and upload it.

Take care,

Daniel


-----Original Message-----
From: Claus Ibsen [mailto:claus.ibsen@gmail.com] 
Sent: Tuesday, February 12, 2013 9:09 AM
To: dev@camel.apache.org
Subject: Re: Support for zip (de)compression

On Tue, Feb 12, 2013 at 11:34 AM, Henryk Konsek <hekonsek@gmail.com>
wrote:
> Hi Daniel,
>
>> The current ZipDataFormat actually
>> implements "deflate" (de)compression.
>
> I like this idea, as I needed such component myself.
>
> I suggest however to rename it to camel-zipfile data format, because
> a) zip2 should be reserved for better version of existing zip
> component b) 'zipfile' is more descriptive in the terms of what this
> data format actually does.
>
> I suggest also to use the exchange id as the default entry name while
> marshaling (instead of "file").
>
> Updated version of the patch will be highly appreciated :) .
>

Yeah well spotted Henryk. I like your suggestions.



> Best regards.
>
> --
> Henryk Konsek
> http://henryk-konsek.blogspot.com



-- 
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen

Mime
View raw message