Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (athena.apache.org: domain of andrea.tarocchi@gmail.com
 designates 209.85.212.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <91CBE3F18E2F46BA93DBBDBF9031BF0B@gmail.com>
References: <20130108221847.2E37211790@tyr.zones.apache.org>
	<E856230BF20D4237AF93B08C01A64AA7@gmail.com>
	<CAD3A9nPKiEN_OeUcBAxv_ae0k5tQ+YTLwJG7Gss2kU4kv_-X_g@mail.gmail.com>
	<91CBE3F18E2F46BA93DBBDBF9031BF0B@gmail.com>
Date: Wed, 9 Jan 2013 09:33:50 +0100
Message-ID: 
 <CAD3A9nOHfOMfnJ9htotsRXDnTuYhta18Sej_t_ka5tgh0AGbJg@mail.gmail.com>
Subject: Re: camel pull request: Corrected handling of charset in
 Hl7Dataformat,
From: Andrea Tarocchi <andrea.tarocchi@gmail.com>
To: dev@camel.apache.org
Content-Type: multipart/alternative; boundary=14dae9d253b4ff153b04d2d6eb58

--14dae9d253b4ff153b04d2d6eb58
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: quoted-printable

Hi,
sorry for the reformatting part :)

I think you understand the changes correctly.

There are only two missing tests:
I understand that the two missing tests 'testUnmarshalISO8859' and
'testUnmarshalIUTF8'
aren't strictly related to the change but I think that could be useful for
documenting purpose and future changes.
I mean just for remember that also the unmarshal need to care about
charset.

Andrea.


On Wed, Jan 9, 2013 at 9:12 AM, Willem jiang <willem.jiang@gmail.com> wrote=
:

> Hi Andrea,
> I found you did some reformat on the code, it is hard for me to find whic=
h
> part of code you changed.
> I tried my best to figure out the actual useful changes before I commit
> the code.
> Please let me know if there is some thing missing on this commit[1].
>
>
> [1]http://svn.apache.org/viewvc?rev=3D1430724&view=3Drev
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/)
> (English)
>           http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: =BD=AA=C4=FEwillem
>
>
>
>
>
> On Wednesday, January 9, 2013 at 3:09 PM, Andrea Tarocchi wrote:
>
> > Ok!
> >
> > the patch is already attached at the jira issue mentioned in the pull
> > request.
> >
> > If you need something else let me know.
> >
> > Andrea.
> > Il giorno 09/gen/2013 02:46, "Willem jiang" <willem.jiang@gmail.com(mai=
lto:
> willem.jiang@gmail.com)> ha
> > scritto:
> >
> > > As ASF project doesn't support to commit through the git currently, w=
e
> > > still need to use git-svn to commit the patch.
> > > Attaching the patch into JIRA should be fine and I will take care of
> this
> > > patch today.
> > >
> > >
> > > --
> > > Willem Jiang
> > >
> > > Red Hat, Inc.
> > > FuseSource is now part of Red Hat
> > > Web: http://www.fusesource.com | http://www.redhat.com
> > > Blog: http://willemjiang.blogspot.com (
> http://willemjiang.blogspot.com/)
> > > (English)
> > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> > > Twitter: willemjiang
> > > Weibo: =BD=AA=C4=FEwillem
> > >
> > >
> > >
> > >
> > >
> > > On Wednesday, January 9, 2013 at 6:18 AM, valdar wrote:
> > >
> > > > GitHub user valdar opened a pull request:
> > > >
> > > > https://github.com/apache/camel/pull/6
> > > >
> > > > Corrected handling of charset in Hl7Dataformat,
> > > >
> > > > See jira issue CAMEL-5943:
> > > > https://issues.apache.org/jira/browse/CAMEL-5943
> > > >
> > > > You can merge this pull request into a Git repository by running:
> > > >
> > > > $ git pull https://github.com/valdar/camel trunk
> > > >
> > > > Alternatively you can review and apply these changes as the patch a=
t:
> > > >
> > > > https://github.com/apache/camel/pull/6.patch
> > > >
> > > > ----
> > > > commit 1c98d13e2382b4ee7a37874d2db4b0ebb8e1c02d
> > > > Author: valdar <valdar@branko>
> > > > Date: 2013-01-08T21:39:49Z
> > > >
> > > > Corrected handling of charset in Hl7Dataformat,
> > > > tested.
> > > >
> > > > ----
>
>
>


--=20
"In a world without walls and fences who needs Windows and Gates?"

--14dae9d253b4ff153b04d2d6eb58--