Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (nike.apache.org: domain of willem.jiang@gmail.com
 designates 209.85.160.44 as permitted sender)
Date: Wed, 12 Dec 2012 12:38:45 +0800
From: Willem jiang <willem.jiang@gmail.com>
To: dev@camel.apache.org
Message-ID: <4D52FD27527F4F238FC30D02EA50A94B@gmail.com>
In-Reply-To: <20121211220634.40FB2238890B@eris.apache.org>
References: <20121211220634.40FB2238890B@eris.apache.org>
Subject: Re: svn commit: r1420455 -
 =?utf-8?Q?/camel/trunk/camel-core/src/main/java/org/apache/camel/processor/WrapProcessor.java?=
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi Christian=EF=BC=8C

This change breaks some unit tests of camel-core, can you have a look at =
them =3F

BTW, wrap=5Borg.apache.camel.processor.DefaultErrorHandlerOnExceptionTrac=
eTest=24MyProcessor=40301a69c=5D  is really a good trace lab for us to us=
e.

=46ailed tests: =20
testOk(org.apache.camel.processor.DefaultErrorHandlerOnExceptionTraceTest=
): expected:<=5Bref:myProcessor=5D> but was:<=5Bwrap=5Borg.apache.camel.p=
rocessor.DefaultErrorHandlerOnExceptionTraceTest=24MyProcessor=40301a69c=5D=
=5D>
testWithError(org.apache.camel.processor.DefaultErrorHandlerOnExceptionTr=
aceTest): expected:<=5Bref:myProcessor=5D> but was:<=5Bwrap=5Borg.apache.=
camel.processor.DefaultErrorHandlerOnExceptionTraceTest=24MyProcessor=401=
0042865=5D=5D>
testSynchronizeComplete(org.apache.camel.processor.OnCompletionGlobalTrac=
eTest): expected:<=5Bref:myProcessor=5D> but was:<=5Bwrap=5Borg.apache.ca=
mel.processor.OnCompletionGlobalTraceTest=24MyProcessor=404f4c55e7=5D=5D>=

testSynchronize=46ailure(org.apache.camel.processor.OnCompletionGlobalTra=
ceTest): expected:<=5Bref:myProcessor=5D> but was:<=5Bwrap=5Borg.apache.c=
amel.processor.OnCompletionGlobalTraceTest=24MyProcessor=40256949fd=5D=5D=
>


-- =20
Willem Jiang

Red Hat, Inc.
=46useSource is now part of Red Hat
Web: http://www.fusesource.com =7C http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) =
(English)
          http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang =20
Weibo: =E5=A7=9C=E5=AE=81willem


On Wednesday, December 12, 2012 at 6:06 AM, cmueller=40apache.org (mailto=
:cmueller=40apache.org) wrote:

> Author: cmueller
> Date: Tue Dec 11 22:06:32 2012
> New Revision: 1420455
> =20
> URL: http://svn.apache.org/viewvc=3Frev=3D1420455&view=3Drev
> Log:
> CAMEL-5844: Camel Tracer not showing some EIP names
> =20
> Modified:
> camel/trunk/camel-core/src/main/java/org/apache/camel/processor/WrapPro=
cessor.java
> =20
> Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/process=
or/WrapProcessor.java
> URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/=
org/apache/camel/processor/WrapProcessor.java=3Frev=3D1420455&r1=3D142045=
4&r2=3D1420455&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- camel/trunk/camel-core/src/main/java/org/apache/camel/processor/Wra=
pProcessor.java (original)
> +++ camel/trunk/camel-core/src/main/java/org/apache/camel/processor/Wra=
pProcessor.java Tue Dec 11 22:06:32 2012
> =40=40 -19,14 +19,14 =40=40 package org.apache.camel.processor;
> import java.util.List;
> =20
> import org.apache.camel.Processor;
> +import org.apache.camel.Traceable;
> import org.apache.camel.util.ServiceHelper;
> =20
> /**
> * A processor which ensures wrapping processors is having lifecycle han=
dled.
> - *
> - * =40version =20
> */
> -public class WrapProcessor extends DelegateAsyncProcessor =7B
> +public class WrapProcessor extends DelegateAsyncProcessor implements T=
raceable =7B
> +
> private final Processor wrapped;
> =20
> public WrapProcessor(Processor processor, Processor wrapped) =7B
> =40=40 -38,6 +38,10 =40=40 public class WrapProcessor extends Deleg
> public String toString() =7B
> return =22Wrap=5B=22 + wrapped + =22=5D -> =22 + processor;
> =7D
> + =20
> + public String getTraceLabel() =7B
> + return =22wrap=5B=22 + wrapped + =22=5D=22;
> + =7D
> =20
> =40Override
> public List<Processor> next() =7B
> =20