camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml
Date Fri, 28 Dec 2012 13:08:46 GMT
On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang <willem.jiang@gmail.com> wrote:
> The CamelSpringTestSupport is marked as @deprecated already, it will be removed in Camel
3.0.
Okay so we have already prepared for that.

> I think ExcludingPackageScanClassResolver can be move to camel-test as it has no other
dependency of Spring.

Yeah then thats fine +1


>
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Web: http://www.fusesource.com | http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>           http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
>
>
> On Friday, December 28, 2012 at 8:30 PM, Claus Ibsen wrote:
>
>> On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang <willem.jiang@gmail.com (mailto:willem.jiang@gmail.com)>
wrote:
>> > It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver
to the camel-test to avoid exporting the package of org.apache.camel.test.
>> >
>> > Any suggestion ?
>>
>> Maybe a better solution could be to
>>
>> copy these 2 classes to the spring package.
>> And then the let the original classes be stubs (eg extend the copied
>> classes), and mark these as @deprecated.
>> And refer ppl to use the classes from the spring package.
>>
>> Then in Camel 3.0 we can remove these 2 classes so the package is
>> empty in camel-test-spring.
>> Then we wont have any split package anymore.
>>
>> And ppl on 2.x can keep code as is. And for 3.0 they need to migrate
>> the code, which would be acceptable.
>>
>> >
>> > --
>> > Willem Jiang
>> >
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Web: http://www.fusesource.com | http://www.redhat.com
>> > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English)
>> > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > Twitter: willemjiang
>> > Weibo: 姜宁willem
>> >
>> >
>> >
>> > On Friday, December 28, 2012 at 4:50 PM, Willem jiang wrote:
>> >
>> > > Hi Claus,
>> > >
>> > > Thanks for pointing that out. I will commit the fix shortly.
>> > >
>> > > --
>> > > Willem Jiang
>> > >
>> > > Red Hat, Inc.
>> > > FuseSource is now part of Red Hat
>> > > Web: http://www.fusesource.com | http://www.redhat.com
>> > > Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/)
(English)
>> > > http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
>> > > Twitter: willemjiang
>> > > Weibo: 姜宁willem
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > On Friday, December 28, 2012 at 4:38 PM, Claus Ibsen wrote:
>> > >
>> > > > Hi
>> > > >
>> > > > I think something broke camel-testng (eg TestNG). This morning I get
>> > > > this compilation error with latest code
>> > > >
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [INFO] BUILD FAILURE
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [INFO] Total time: 3:23.882s
>> > > > [INFO] Finished at: Fri Dec 28 09:38:26 CET 2012
>> > > > [INFO] Final Memory: 129M/370M
>> > > > [INFO] ------------------------------------------------------------------------
>> > > > [ERROR] Failed to execute goal
>> > > > org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile
>> > > > (default-compile) on project camel-testng: Compilation failure:
>> > > > Compilation failure:
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[26,28]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: package org.apache.camel.test
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[126,97]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,8]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] /Users/davsclaus/workspace/camel/components/camel-testng/src/main/java/org/apache/camel/testng/CamelSpringTestSupport.java:[129,113]
>> > > > cannot find symbol
>> > > > [ERROR] symbol : class ExcludingPackageScanClassResolver
>> > > > [ERROR] location: class org.apache.camel.testng.CamelSpringTestSupport
>> > > > [ERROR] -> [Help 1]
>> > > > [ERROR]
>> > > > [ERROR] To see the full stack trace of the errors, re-run Maven with
>> > > > the -e switch.
>> > > > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> > > > [ERROR]
>> > > > [ERROR] For more information about the errors and possible solutions,
>> > > > please read the following articles:
>> > > > [ERROR] [Help 1]
>> > > > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
>> > > > [ERROR]
>> > > > [ERROR] After correcting the problems, you can resume the build with
the command
>> > > > [ERROR] mvn <goals> -rf :camel-testng
>> > > >
>> > > >
>> > > > On Fri, Dec 28, 2012 at 4:39 AM, <ningjiang@apache.org (mailto:ningjiang@apache.org)>
wrote:
>> > > > > Author: ningjiang
>> > > > > Date: Fri Dec 28 03:39:15 2012
>> > > > > New Revision: 1426385
>> > > > >
>> > > > > URL: http://svn.apache.org/viewvc?rev=1426385&view=rev
>> > > > > Log:
>> > > > > CAMEL-5915 fixed the camel-test-spring mixed up no related classes
issue
>> > > > >
>> > > > > Modified:
>> > > > > camel/trunk/components/camel-test-spring/pom.xml
>> > > > >
>> > > > > Modified: camel/trunk/components/camel-test-spring/pom.xml
>> > > > > URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-test-spring/pom.xml?rev=1426385&r1=1426384&r2=1426385&view=diff
>> > > > > ==============================================================================
>> > > > > --- camel/trunk/components/camel-test-spring/pom.xml (original)
>> > > > > +++ camel/trunk/components/camel-test-spring/pom.xml Fri Dec
28 03:39:15 2012
>> > > > > @@ -32,7 +32,7 @@
>> > > > >
>> > > > > <properties>
>> > > > > <spring-version>${spring31-version}</spring-version>
>> > > > > - <camel.osgi.export.pkg>org.apache.camel.test.*</camel.osgi.export.pkg>
>> > > > > + <camel.osgi.export.pkg>org.apache.camel.test.spring.*</camel.osgi.export.pkg>
>> > > > > </properties>
>> > > > >
>> > > > > <dependencies>
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Claus Ibsen
>> > > > -----------------
>> > > > Red Hat, Inc.
>> > > > FuseSource is now part of Red Hat
>> > > > Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> > > > Web: http://fusesource.com
>> > > > Twitter: davsclaus
>> > > > Blog: http://davsclaus.com
>> > > > Author of Camel in Action: http://www.manning.com/ibsen
>> > >
>> >
>>
>>
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> Red Hat, Inc.
>> FuseSource is now part of Red Hat
>> Email: cibsen@redhat.com (mailto:cibsen@redhat.com)
>> Web: http://fusesource.com
>> Twitter: davsclaus
>> Blog: http://davsclaus.com
>> Author of Camel in Action: http://www.manning.com/ibsen
>
>
>



-- 
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen

Mime
View raw message