camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: svn commit: r1409651 - in /camel/trunk: components/camel-cxf/src/test/java/org/apache/camel/component/cxf/ examples/camel-example-loan-broker/src/main/java/org/apache/camel/loanbroker/webservice/version/
Date Thu, 15 Nov 2012 13:47:08 GMT
Hi

Dan thanks for sharing this. I guess we should go over the example
tests and make sure they shutdown properly.
Those tests Willem is trying to fix, hasn't been surfaced as often, as
these tests is run last.
And as many times the CI server may not get so far.

What we have seen is that these tests fails more often on AIX, than
the other platforms.
Though we reached the end of the test suite (eg it was able to attempt
all tests)

So we (I guess its my work to do) can enable the AIX tests again, as
we have a "complete picture" now, where those examples tests are the
last issues covered.

BTW: Any chance you guys have seen AIX test failures in Apache CXF
project itself? And if so do you guys run on both Java6 and Java7?

A piece of a stracetrace shows NPE in CXF itself, but it may be a side
effect of something else.

2012-11-13 17:51:20,388 [main           ] WARN  PhaseInterceptorChain
        - Interceptor for
{http://version.webservice.loanbroker.camel.apache.org/}LoanBrokerWS#{http://version.webservice.loanbroker.camel.apache.org/}getLoanQuote
has thrown exception, unwinding now
java.lang.NullPointerException
	at org.apache.cxf.endpoint.AbstractConduitSelector.getSelectedConduit(AbstractConduitSelector.java:90)



On Thu, Nov 15, 2012 at 1:47 PM, Daniel Kulp <dkulp@apache.org> wrote:
>
> Willem,
>
> If BusFactory.newInstance().createBus() is doing something different than BusFactory.getDefaultBus(),
then likely there is a test ahead of it that doesn't have a proper teardown that is shutting
down the bus.   That needs to get fixed.
>
> More importantly, you are now creating a bus and not shutting it down anywhere.   Thus,
you are now possibly causing issues for the next tests.  I'm OK with creating the new bus
to make sure you get a clean slate, but make sure it gets shutdown.
>
> Dan
>
>
>
> On Nov 15, 2012, at 12:32 AM, ningjiang@apache.org wrote:
>
>> Author: ningjiang
>> Date: Thu Nov 15 05:32:26 2012
>> New Revision: 1409651
>>
>> URL: http://svn.apache.org/viewvc?rev=1409651&view=rev
>> Log:
>> Try to fix the camel-cxf related test failures
>>
>> Modified:
>>    camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerTest.java
>>    camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfMixedModeRouterTest.java
>>    camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfPayLoadBareSoapTest.java
>>    camel/trunk/examples/camel-example-loan-broker/src/main/java/org/apache/camel/loanbroker/webservice/version/Client.java
>>
>> Modified: camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerTest.java
>> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerTest.java?rev=1409651&r1=1409650&r2=1409651&view=diff
>> ==============================================================================
>> --- camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerTest.java
(original)
>> +++ camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfConsumerTest.java
Thu Nov 15 05:32:26 2012
>> @@ -104,7 +104,7 @@ public class CxfConsumerTest extends Cam
>>         ClientFactoryBean clientBean = proxyFactory.getClientFactoryBean();
>>         clientBean.setAddress(SIMPLE_ENDPOINT_ADDRESS);
>>         clientBean.setServiceClass(HelloService.class);
>> -        clientBean.setBus(BusFactory.getDefaultBus());
>> +        clientBean.setBus(BusFactory.newInstance().createBus());
>>
>>         HelloService client = (HelloService) proxyFactory.create();
>>
>>
>> Modified: camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfMixedModeRouterTest.java
>> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfMixedModeRouterTest.java?rev=1409651&r1=1409650&r2=1409651&view=diff
>> ==============================================================================
>> --- camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfMixedModeRouterTest.java
(original)
>> +++ camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfMixedModeRouterTest.java
Thu Nov 15 05:32:26 2012
>> @@ -30,6 +30,7 @@ import org.apache.camel.component.cxf.co
>> import org.apache.camel.converter.jaxp.XmlConverter;
>> import org.apache.camel.impl.DefaultCamelContext;
>> import org.apache.camel.test.junit4.CamelTestSupport;
>> +import org.apache.cxf.BusFactory;
>> import org.apache.cxf.binding.soap.SoapHeader;
>> import org.apache.cxf.endpoint.Server;
>> import org.apache.cxf.frontend.ClientFactoryBean;
>> @@ -145,7 +146,8 @@ public class CxfMixedModeRouterTest exte
>>         ClientProxyFactoryBean proxyFactory = new ClientProxyFactoryBean();
>>         ClientFactoryBean clientBean = proxyFactory.getClientFactoryBean();
>>         clientBean.setAddress(ROUTER_ADDRESS);
>> -        clientBean.setServiceClass(HelloService.class);
>> +        clientBean.setServiceClass(HelloService.class);
>> +        clientBean.setBus(BusFactory.newInstance().createBus());
>>
>>         HelloService client = (HelloService) proxyFactory.create();
>>         return client;
>>
>> Modified: camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfPayLoadBareSoapTest.java
>> URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfPayLoadBareSoapTest.java?rev=1409651&r1=1409650&r2=1409651&view=diff
>> ==============================================================================
>> --- camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfPayLoadBareSoapTest.java
(original)
>> +++ camel/trunk/components/camel-cxf/src/test/java/org/apache/camel/component/cxf/CxfPayLoadBareSoapTest.java
Thu Nov 15 05:32:26 2012
>> @@ -25,6 +25,7 @@ import javax.xml.ws.Endpoint;
>> import org.apache.camel.builder.RouteBuilder;
>> import org.apache.camel.test.AvailablePortFinder;
>> import org.apache.camel.test.junit4.CamelTestSupport;
>> +import org.apache.cxf.BusFactory;
>> import org.apache.cxf.frontend.ClientProxyFactoryBean;
>> import org.junit.BeforeClass;
>> import org.junit.Test;
>> @@ -66,6 +67,7 @@ public class CxfPayLoadBareSoapTest exte
>>         ClientProxyFactoryBean factory = new ClientProxyFactoryBean();
>>         factory.setServiceClass(BareSoapService.class);
>>         factory.setAddress(PROXY_URL);
>> +        factory.setBus(BusFactory.newInstance().createBus());
>>         BareSoapService client = (BareSoapService) factory.create();
>>
>>         client.doSomething();
>>
>> Modified: camel/trunk/examples/camel-example-loan-broker/src/main/java/org/apache/camel/loanbroker/webservice/version/Client.java
>> URL: http://svn.apache.org/viewvc/camel/trunk/examples/camel-example-loan-broker/src/main/java/org/apache/camel/loanbroker/webservice/version/Client.java?rev=1409651&r1=1409650&r2=1409651&view=diff
>> ==============================================================================
>> --- camel/trunk/examples/camel-example-loan-broker/src/main/java/org/apache/camel/loanbroker/webservice/version/Client.java
(original)
>> +++ camel/trunk/examples/camel-example-loan-broker/src/main/java/org/apache/camel/loanbroker/webservice/version/Client.java
Thu Nov 15 05:32:26 2012
>> @@ -38,7 +38,8 @@ public final class Client {
>>         ClientFactoryBean clientBean = proxyFactory.getClientFactoryBean();
>>         clientBean.setAddress(address);
>>         clientBean.setServiceClass(LoanBrokerWS.class);
>> -        clientBean.setBus(BusFactory.getDefaultBus());
>> +        // just create a new bus for use
>> +        clientBean.setBus(BusFactory.newInstance().createBus());
>>         return (LoanBrokerWS) proxyFactory.create();
>>     }
>>
>>
>>
>
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>



-- 
Claus Ibsen
-----------------
Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen

Mime
View raw message