Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (athena.apache.org: domain of willem.jiang@gmail.com
 designates 209.85.160.45 as permitted sender)
Date: Mon, 22 Oct 2012 11:19:32 +0800
From: Willem jiang <willem.jiang@gmail.com>
To: dev@camel.apache.org
Message-ID: <86AFCA85527648FC8213C2552B8F3309@gmail.com>
In-Reply-To: <000FA6853AFD465FA984D52F36111016@gmail.com>
References: 
 <CAKoNANsoC4rsvJCLKnsRBqhKM2QOOG3Txta+hF_zUaUwvOYN5g@mail.gmail.com>
 <CAKoNANvv5qE=+uifjEstuskmcgVdSHsuVQn5wZEyQp=NR434LA@mail.gmail.com>
 <000FA6853AFD465FA984D52F36111016@gmail.com>
Subject: Re: [HEADS UP] Classloader mixup with Jetty consumers
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Just one comment from the TCCL setting on the CamelContinuationServletl=EF=
=BC=8C the unit test that you added doesn't have the thread switch even w=
e used the async invocation API.
So we need to set the TCCL somewhere incase the we need to use the camel =
application class loader in the other thread.


-- =20
Willem Jiang

Red Hat, Inc.
=46useSource is now part of Red Hat
Web: http://www.fusesource.com =7C http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) =
(English)
          http://jnn.javaeye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang =20
Weibo: willemjiang


On Monday, October 22, 2012 at 11:04 AM, Willem jiang wrote:

> Hi Raul,
> =20
> The patches are looking good. =20
> +1 for back porting them into 2.10.x and 2.9.x.
> =20
> -- =20
> Willem Jiang
> =20
> Red Hat, Inc.
> =46useSource is now part of Red Hat
> Web: http://www.fusesource.com =7C http://www.redhat.com
> Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/=
) (English)
> http://jnn.javaeye.com (http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang =20
> Weibo: willemjiang
> =20
> =20
> =20
> =20
> =20
> On Monday, October 22, 2012 at 6:30 AM, Raul Kripalani wrote:
> =20
> > Now also correcting the TCCL on Jetty consumers with disabled
> > continuations: http://svn.apache.org/viewvc=3Fview=3Drevision&revisio=
n=3D1400734.
> > =20
> > Regards,
> > =20
> > *Ra=C3=BAl Kripalani*
> > Apache Camel Committer
> > Enterprise Architect, Program Manager, Open Source Integration specia=
list
> > http://about.me/raulkripalani =7C http://www.linkedin.com/in/raulkrip=
alani
> > http://blog.raulkr.net =7C twitter: =40raulvk <http://twitter.com/rau=
lvk>
> > =20
> > On Sun, Oct 21, 2012 at 10:55 PM, Raul Kripalani <raul=40evosent.com =
(mailto:raul=40evosent.com)> wrote:
> > =20
> > > Hello,
> > > =20
> > > I've come across what I consider a critical bug in camel-jetty, giv=
en the
> > > installed base of that component.
> > > =20
> > > When multiple Camel Contexts expose camel-jetty consumers on the sa=
me TCP
> > > port, they share the underlying Jetty Connector. As a side effect o=
f this, the
> > > route runs with the classloader of the bundle/WAR that happened to =
create
> > > the Connector first, i.e. the Camel Context whose Jetty consumer st=
arted
> > > first.
> > > =20
> > > The issue shows up in OSGi environments or Application Servers or
> > > containers that provide per-application or per-deployable classload=
ers.
> > > Classloader isolation is effectively broken, so if bundle A and bun=
dle B
> > > both have Jetty consumers on port 9010 and bundle A starts first, t=
he
> > > requests routed to B will have the class loader from bundle A as th=
e TCCL.
> > > Thus, class resolution performed by B may fail if the OSGi imports =
are not
> > > equal.
> > > =20
> > > The issue is logged under https://issues.apache.org/jira/browse/CAM=
EL-5722.
> > > I committed a fix to trunk along with an OSGi Integration test on t=
he
> > > following revision:
> > > http://svn.apache.org/viewvc=3Fview=3Drevision&revision=3D1400729.
> > > =20
> > > Would someone mind taking a quick look at this fix=3F If all seems =
correct,
> > > I'll backport onto 2.9.x and 2.10.x.
> > > =20
> > > Thanks=21
> > > =20
> > > *Ra=C3=BAl Kripalani*
> > > Apache Camel Committer
> > > Enterprise Architect, Program Manager, Open Source Integration spec=
ialist
> > > http://about.me/raulkripalani =7C http://www.linkedin.com/in/raulkr=
ipalani
> > > http://blog.raulkr.net =7C twitter: =40raulvk <http://twitter.com/r=
aulvk>
> > =20
> =20