Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: neutral (nike.apache.org: 216.139.236.26 is neither permitted
 nor denied by domain of cmoulliard@gmail.com)
Date: Wed, 4 Jul 2012 23:14:53 -0700 (PDT)
From: Charles Moulliard <cmoulliard@gmail.com>
To: dev@camel.apache.org
Message-ID: <1341468893106-5715512.post@n5.nabble.com>
In-Reply-To: 
 <CACLE=7PR21Tac61zCU-Eu0Fe9-Zd5t6gb_SevaMaX5Kw3uDS=Q@mail.gmail.com>
References: 
 <CACLE=7PR21Tac61zCU-Eu0Fe9-Zd5t6gb_SevaMaX5Kw3uDS=Q@mail.gmail.com>
Subject: Re: camel cdi extension
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi Romain,

This is really interesting what you have have developed. I don't really like
how you add RouteBuilder in the create method (class CamelContextBean) and I
would prefer that the user can provide this information like we do in a more
Camel traditional way. By the way, I suggest that in the CamelContextBean
class (method create) we use CdiCamelContext as it implements Camel Registry
to do CDI bean lookup in the registry. 

@Inject
@CamelContextId("context1")
private CamelContext ctx1;

ctx1.addRoutes(new MyRouteBuilder())

Remark : camel-cdi (2.10) allows already to do this ;-)

@Inject
protected CdiCamelContext camelCtx;

@Inject
protected org.fusesource.example.cdi.camel.SimpleCamelRoute simpleRoute;
 ...

 simpleRoute.setTimerUri("timer://simple?fixedRate=true&period=10s");

 // Add Camel Route
 camelCtx.addRoutes(simpleRoute);

So what could be the benefit to use this CDI extension ?

I will have a look on that today.

Regards,

Charles

-----
Apache Committer / Sr. Pr. Consultant at FuseSource.com
Email: [hidden email]
Twitter : @cmoulliard, @fusenews
Blog : http://cmoulliard.blogspot.com
--
View this message in context: http://camel.465427.n5.nabble.com/camel-cdi-extension-tp5715506p5715512.html
Sent from the Camel Development mailing list archive at Nabble.com.