camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: Camel-Extra 2.10 release
Date Wed, 11 Jul 2012 09:01:17 GMT
On Wednesday, July 11, 2012 12:31:35 AM Christian Müller wrote:
> Hello Henryk, hello Dan,
> 
> @Henryk: Thanks for your work!
> 
> @Dan: I will go forward with this tomorrow (or may be Henryk if he find
> some time) and change this line from the license header. Than I would
> suggest to use the following license header:
> 
> /*************************************************************************
> ************* 2008 - 2012 Camel Extra Team.
>   http://code.google.com/a/apache-extras.org/p/camel-extra/

Without a copyright statement, the date range is kind of pointless and just 
something else to keep updating.   I'd pull that as well.

Dan


> 
>   This program is free software; you can redistribute it and/or
>   modify it under the terms of the GNU General Public License
>   as published by the Free Software Foundation; either version 2
>   of the License, or (at your option) any later version.
> 
>   This program is distributed in the hope that it will be useful,
>   but WITHOUT ANY WARRANTY; without even the implied warranty of
>   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   GNU General Public License for more details.
> 
>   You should have received a copy of the GNU General Public License
>   along with this program; if not, write to the Free Software
>   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301, USA.
> 
>   http://www.gnu.org/licenses/gpl-2.0-standalone.html
> **************************************************************************
> *************/
> 
> You are fine with this?
> 
> Best,
> Christian
> 
> On Tue, Jul 10, 2012 at 7:13 PM, Daniel Kulp <dkulp@apache.org> wrote:
> > > Check my commit please :) .
> > > 
> > > [1] Small version of license:
> > >  <!--
> > >  
> > >   Copyright (C) 2008 - 2012 Camel Extra Team. All rights reserved.
> > >   http://code.google.com/a/apache-extras.org/p/camel-extra/
> > >   
> > >   The software in this package is published under the terms of the GPL
> > > 
> > > license a copy of which has been included with this distribution in
> > > the
> > > license.txt file.
> > > -->
> > 
> > As I stated before, this license header is likely wrong.  The code in
> > the
> > files is most likely NOT copyright "Camel Extra Team" and thus that line
> > needs to be removed.  Unless there is a specific copyright transfer, the
> > original authors (or their employer) would hold the copyright on the
> > individual changes and files.    That is exactly why the Apache license
> > header does not have that in it.
> > 
> > Please remove that.
> > 
> > 
> > Dan
> > 
> > On Tuesday, July 10, 2012 06:15:42 PM Henryk Konsek wrote:
> > > > Ok done. I only need to reformat the POM XML to look nicer and then
> > > > can
> > > > commit.
> > > 
> > > Ok, commit submitted (rev896).
> > > 
> > > I've added 'withRatCheck' profile to the project so you can check it
> > > against RAT validation issuing 'mvn install -PwithRatCheck'. This is a
> > > good alternative for calling 'mvn
> > > org.apache.rat:apache-rat-plugin:check' since 'mvn rat:check' is
> > > reserved for old 'org.codehaus.mojo:rat-maven-plugin:check' version of
> > > RAT plugin.
> > > 
> > > Now we're looking for pattern 'You should have received a copy of the
> > > GNU General Public License' since we want to replace the old small
> > > version of license [1] with the new long one (which is currently under
> > > public discussion). After we remove the small [1] licenses we will
> > > change pattern to more descriptive one, like 'Copyright (C) 2008 -
> > > 2012 Camel Extra Team. All rights reserved.' (we can't use this one
> > > now since it is included in the small [1] version of the license).
> > > 
> > > After new version of extra license will be discussed and accepted,
> > > I'll validate the camel-extra build against the 'mvn install
> > > -PwithRatCheck' profile and apply new license to all required files in
> > > the project.
> > > 
> > > Check my commit please :) .
> > > 
> > > [1] Small version of license:
> > >  <!--
> > >  
> > >   Copyright (C) 2008 - 2012 Camel Extra Team. All rights reserved.
> > >   http://code.google.com/a/apache-extras.org/p/camel-extra/
> > >   
> > >   The software in this package is published under the terms of the GPL
> > > 
> > > license a copy of which has been included with this distribution in
> > > the
> > > license.txt file.
> > > -->
> > 
> > --
> > Daniel Kulp
> > dkulp@apache.org - http://dankulp.com/blog
> > Talend Community Coder - http://coders.talend.com
-- 
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com

Mime
View raw message