Return-Path: X-Original-To: apmail-camel-dev-archive@www.apache.org Delivered-To: apmail-camel-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F978C8FF for ; Wed, 6 Jun 2012 06:35:15 +0000 (UTC) Received: (qmail 31516 invoked by uid 500); 6 Jun 2012 06:35:15 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 31148 invoked by uid 500); 6 Jun 2012 06:35:08 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 31092 invoked by uid 99); 6 Jun 2012 06:35:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2012 06:35:05 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of hekonsek@gmail.com designates 209.85.161.173 as permitted sender) Received: from [209.85.161.173] (HELO mail-gg0-f173.google.com) (209.85.161.173) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2012 06:34:59 +0000 Received: by ggnp1 with SMTP id p1so5476350ggn.32 for ; Tue, 05 Jun 2012 23:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=4V50q5ZsdbE1Hr+dGqKlF/KHMQDYLvK82IUDvs6I9GA=; b=EbSSW1eOoHz26XzRBB7ovm3y9K6YFARRaGIWRBCHcTrS0BC/7ZG/oplgZikCIzH1PW yPjIwiRpa655BNvCietFNzy+547KgR0SfWnuTNrIpmrGhM9NJsqyBlcz8eIf5+5C8eNX DU+fh6rWpOINrBeZZ7cMpE718hlJLvRjw9LXtDTCq8DVSXVZwzcP6FZ6vLa/+W3kxkeA vYRn69KevxU9zgNjU9y+h8diEkQ47LBBIl38+GtIezcNpkbmFBrku4HCgZlUG3OnPnCW ljxvqz1EcpnWESDQIjmHo1gMiCjzaAGlUjnqWQ/piHcg7opN34uLThQRzxulwLey9VXp GVog== MIME-Version: 1.0 Received: by 10.236.103.106 with SMTP id e70mr14839465yhg.62.1338964478437; Tue, 05 Jun 2012 23:34:38 -0700 (PDT) Received: by 10.236.170.104 with HTTP; Tue, 5 Jun 2012 23:34:38 -0700 (PDT) Date: Wed, 6 Jun 2012 08:34:38 +0200 Message-ID: Subject: Improved the test coverage of Camel Stream component From: Henryk Konsek To: dev@camel.apache.org Content-Type: text/plain; charset=ISO-8859-1 Hi, I've improved the test coverage of Camel Stream component. In particular I've added: a) tests for Stream producer writing to the URL output stream (StreamToUrlTest). b) assertions to StreamSystemOutTest. Previously we've been sending a messages to the System.out but made no assertions about it. This looked like the AssertionFreeTesting [1]. :) I changed the test to temporarily switch System.out with another PrintStream instance so we could make some assertions on it. Could somebody take a look at patch and possibly apply it to the trunk? Here is Jira ticket [2] for this issue. Best regards. [1] http://martinfowler.com/bliki/AssertionFreeTesting.html [2] https://issues.apache.org/jira/browse/CAMEL-5336 -- Henryk Konsek http://henryk-konsek.blogspot.com