Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (athena.apache.org: domain of hzbarcea@gmail.com designates
 209.85.213.173 as permitted sender)
Message-ID: <4FE1E3E9.6090605@gmail.com>
Date: Wed, 20 Jun 2012 10:53:29 -0400
From: Hadrian Zbarcea <hzbarcea@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: dev@camel.apache.org
Subject: Re: camel-guice Main not using enableHangupSupport
References: 
 <CAJ6eY0YKhsbZZVjZJGYAabjUWCAMAaaDHODJmZTUDWdw-qabGQ@mail.gmail.com>
 <4FE1DF7A.4000801@gmail.com>
 <CAJ6eY0aGcz0RPZVKfsBasBO7tS1FqgAMQPRQzv0GMC7CuqYd_g@mail.gmail.com>
In-Reply-To: 
 <CAJ6eY0aGcz0RPZVKfsBasBO7tS1FqgAMQPRQzv0GMC7CuqYd_g@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Bilgin, commit away :).

There is no set rule, but the preference is obviously to do it right 
away and the original committer to do the backmerge as well (he should 
be the one who knows best). Another advantage is that you get more time 
to test the backport if you do it earlier. We're close to releasing 
2.9.3 so this is good timing.

Thanks again,
Hadrian

On 06/20/2012 10:48 AM, Bilgin Ibryam wrote:
> Hadrian, I will do the change now on trunk (I haven't used my commit right
> that much so far ;)
>
> I got a question though: when do you usually backport the changes from
> trunk to branches: as soon as the commit to trunk, or later - when the
> branch is about to be released?
>
> Bilgin
>
> PS: I've seen
> http://camel.apache.org/merging-commits-from-trunk-to-fixes-branch.html
>
> On 20 June 2012 15:34, Hadrian Zbarcea<hzbarcea@gmail.com>  wrote:
>
>> Bilgin, you are correct, it should. Would you have some time to work on a
>> patch?
>>
>> Thanks,
>> Hadrian
>>
>>
>> On 06/20/2012 09:20 AM, Bilgin Ibryam wrote:
>>
>>> While I was using camel-guice component, I realized that Main class (used
>>> to run Camel from GuiceCamelContext) is actually not using
>>> enableHangupSupport and as a result the app is shut down quickly. The
>>> other
>>> Main class implementations in org.apache.camel.main and
>>> org.apache.camel.spring packages use enableHangupSupport.
>>> I think the camel-guice Main should have the same behaviour, WDYT?
>>>
>>> Bilgin
>>>
>>>
>