camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Babak Vahdat <babak.vah...@swissonline.ch>
Subject About false-positive Test inside Camel source!
Date Tue, 14 Feb 2012 17:38:36 GMT
Hi

Today there was a question on the user forum [1] where I applied a patch
regarding it, however my concern by this post is not the issue user suffered
from but the unit-test [2] which does behave false-positive!

If at the line 147 you would change:

          assertEquals(TEXT, result);

With:
          assertEquals(null, result);

The test would *still* pass!

I looked into it a bit and IMHO the problem is because of
RedeliveryErrorHandler.isDone() [3] which somehow has the effect of:

	 - x - = +     <==     minus multiplied with minus == plus

That's if answer value assigned through:

boolean answer = isCancelledOrInterrupted(exchange);

Is *already* true we should return !answer because as the method name says
we ask for if isDone(). I changed the logic of that method on my workspace
to something making better sense to me and the result was an endless
retrying of routing the failed inflight exchange again and again.

In all cases I assume we've got an issue here, What do you think?

[1]
http://camel.465427.n5.nabble.com/Zipping-the-content-of-several-files-into-one-file-td5481638.html
[2]
https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/test/java/org/apache/camel/impl/ZipDataFormatTest.java
[3]
https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/main/java/org/apache/camel/processor/RedeliveryErrorHandler.java

Babak


--
View this message in context: http://camel.465427.n5.nabble.com/About-false-positive-Test-inside-Camel-source-tp5483171p5483171.html
Sent from the Camel Development mailing list archive at Nabble.com.

Mime
View raw message