camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Babak Vahdat <babak.vah...@swissonline.ch>
Subject [DISCUSS] - About the setup.eclipse Profile we have
Date Tue, 17 Jan 2012 16:19:23 GMT
Hi,

couple of weeks ago I had a long mail conversation with Dan Kulp concerning
(among others) the compiler warnings he
sees by his workspace (just around 40) and I see on my workspace (almost
2000!).

The reason for this deviation was of course the fact that Dan made use of
the setup.eclipse Profile [1] while I just
created my workspace from the scratch using eclipse itself with it's default
settings.

IMHO we should consolidate [2] in that we do *not* ignore what compiler has
to say to us. The same rule also applies
for the Camel users as well who hopefully do *not* ignore the WARNINGs Camel
logs by their apps.

We should better remove all the lines below in [2] and let eclipse use it's
default compiler settings, as you see we
instruct eclipse [2] to just "ignore":


<propertyfile
file="${full.eclipse.workspace}/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.core.prefs">
  <entry key="org.eclipse.jdt.core.compiler.problem.missingSerialVersion"
value="ignore" />
  <entry key="org.eclipse.jdt.core.compiler.problem.unusedImport"
value="ignore" />
  <entry
key="org.eclipse.jdt.core.compiler.problem.annotationSuperInterface"
value="ignore" />
  <entry key="org.eclipse.jdt.core.compiler.problem.rawTypeReference"
value="ignore" />
</propertyfile>

IMHO the worst one is "rawTypeReference" which by it's absence one would get
odd ClassCastException first at *run-time*, however
a proper usage of generics helps to have type-safety at *compile-time*. BTW
I think we should also better make use of
org.apache.camel.util.CastUtils class as little as possible, that's *only*
when there's no other option left!

If (almost) all agree I'll open a ticket to fix this, see also the defaults
[3] of the "-warn" option by the eclipse compiler.

WDYT?

[1] http://camel.apache.org/building.html
[2] https://svn.apache.org/repos/asf/camel/trunk/etc/pom.xml
[3]
http://help.eclipse.org/helios/topic/org.eclipse.jdt.doc.isv/guide/jdt_api_compile.htm

Babak

--
View this message in context: http://camel.465427.n5.nabble.com/DISCUSS-About-the-setup-eclipse-Profile-we-have-tp5152042p5152042.html
Sent from the Camel Development mailing list archive at Nabble.com.

Mime
View raw message