camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Nodet <gno...@gmail.com>
Subject Re: svn commit: r1201768 - /camel/trunk/platforms/karaf/features/src/main/resources/features.xml
Date Mon, 26 Dec 2011 23:14:09 GMT
I'm not talking short term here, so having to release the specs is
good for me, especially if they include the changes i've been talking
about.
For the short term, I've no problems reverting to the previous working state.

On Mon, Dec 26, 2011 at 21:54, Jean-Baptiste Onofré <jb@nanthrax.net> wrote:
> Yes, but the modification is not in the Camel component, it's in the
> ServiceMix spec (it's where the version range should be updated).
>
> I can do the fix, but it requires a new release of ServiceMix specs.
>
> Regards
> JB
>
>
> On 12/26/2011 09:48 PM, Guillaume Nodet wrote:
>>
>> Wouldn't it be easier to fix the imported version ranges of camel-soap
>> instead ?
>> If we think we should be able to deploy it on a plain JRE, we should
>> import jaxb with no version range.
>> I think that should be the case for most of the JRE provided packages.
>>
>> Also, I had done some experiments in deploying modified versions of
>> the servicemix specs in the endorsed folder, and those specs are able
>> to use the JRE implementation if none is provided, or implementations
>> deployed as bundles.  I need to experimenent a bit more on that, but
>> the results were very promising.  That would also mean that the
>> exported package version is the default, so supporting 0.0 is a good
>> thing imho.
>>
>> On Mon, Dec 26, 2011 at 20:59, Jean-Baptiste Onofré<jb@nanthrax.net>
>>  wrote:
>>>
>>> Hi Guillaume,
>>>
>>> first of all, merry Christmas to you and your family ;)
>>>
>>> Let me try to explain the current situation.
>>>
>>> In Camel, we have several features which depend on ServiceMix JAX-WS Spec
>>> (for instance, camel-soap).
>>> The ServiceMix Specs explicitly define an import package like:
>>>
>>> javax.xml.bind;version="2.2.0"
>>>
>>> The jre package exports javax.xml.bind;version=0.0.0 by default.
>>>
>>> So it means that these features are not installable out of the box. The
>>> users have to:
>>> - solution 1: install manually the xml-spec-api feature or the JAXB
>>> bundles
>>> - solution 2: tweak the jre.properties to export the packages with the
>>> 2.2.0
>>> version
>>>
>>> To summarize, it means that these features are not installable out of the
>>> box, which is a change comparing to Camel 2.8.x.
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 12/26/2011 08:09 PM, Guillaume Nodet wrote:
>>>>
>>>>
>>>> Do you have pointers to the problems ? All those packages are provided
>>>> by
>>>> the JRE so they should not have to be installed imho.
>>>> Anyway, I'm in vacation until january so feel free to revert the xml
>>>> definition, i doubt i won't be able to do that this week.
>>>>
>>>> On Monday, December 26, 2011, Daniel Kulp<dkulp@apache.org>    wrote:
>>>>>
>>>>>
>>>>>
>>>>> The discussions around the entire xml-specs/jaxb/etc... stuff in the
>>>>
>>>>
>>>> features
>>>>>
>>>>>
>>>>> file has shown that this commit has caused a lot more problems than
>>>>> it's
>>>>> actually solving.   Thus, I'm officially putting a -1 on this commit
as
>>>>
>>>>
>>>> it's
>>>>>
>>>>>
>>>>> causing breakages in other components,  causes cast exceptions and
>>>>> other
>>>>> issues at runtime, etc....
>>>>>
>>>>> In the future when Karaf can provide better solutions for this issue,
>>>>> we
>>>>
>>>>
>>>> can
>>>>>
>>>>>
>>>>> can resolve this.  But at this point, we need to stay with the same
>>>>
>>>>
>>>> solutions
>>>>>
>>>>>
>>>>> that users are expecting and that have worked fine on the 2.8.x and
>>>>
>>>>
>>>> earlier
>>>>>
>>>>>
>>>>> versions of Camel.
>>>>>
>>>>> In anycase, this needs to be reverted and CAMEL-4671 re-opened until
a
>>>>
>>>>
>>>> better
>>>>>
>>>>>
>>>>> solution can be found.
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>>
>>>>> On Monday, November 14, 2011 4:01:24 PM gnodet@apache.org wrote:
>>>>>>
>>>>>>
>>>>>> Author: gnodet
>>>>>> Date: Mon Nov 14 16:01:24 2011
>>>>>> New Revision: 1201768
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1201768&view=rev
>>>>>> Log:
>>>>>> [CAMEL-4671] The camel-core feature should not reference jaxb2 api
/
>>>>>> impl
>>>>>>
>>>>>> Modified:
>>>>>>
>>>>>> camel/trunk/platforms/karaf/features/src/main/resources/features.xml
>>>>>>
>>>>>> Modified:
>>>>>> camel/trunk/platforms/karaf/features/src/main/resources/features.xml
>>>>>> URL:
>>>>>>
>>>>
>>>>
>>>> http://svn.apache.org/viewvc/camel/trunk/platforms/karaf/features/src/main/
>>>>>>
>>>>>>
>>>>>> resources/features.xml?rev=1201768&r1=1201767&r2=1201768&view=diff
>>>>>>
>>>>
>>>>
>>>> ===========================================================================
>>>>>>
>>>>>>
>>>>>> === ---
>>>>
>>>>
>>>> camel/trunk/platforms/karaf/features/src/main/resources/features.xml
>>>>>>
>>>>>>
>>>>>> (original) +++
>>>>>> camel/trunk/platforms/karaf/features/src/main/resources/features.xml
>>>>>> Mon
>>>>>> Nov 14 16:01:24 2011 @@ -25,13 +25,9 @@
>>>>>>    </feature>
>>>>>>    <feature name='camel-core' version='${pom.version}'
>>>>>> resolver='(obr)'
>>>>>> start-level='50'>    <feature version="[3,4)">spring</feature>
>>>>>> -<bundle
>>>>>>
>>>>
>>>>
>>>> dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.spe
>>>>>>
>>>>>>
>>>>>> cs.activation-api-1.1/${servicemix-specs-version}</bundle>
   -<bundle
>>>>>>
>>>>
>>>>
>>>> dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.spe
>>>>>>
>>>>>>
>>>>>> cs.jaxb-api-2.2/${servicemix-specs-version}</bundle>    -<bundle
>>>>>>
>>>>
>>>>
>>>> dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.spe
>>>>>>
>>>>>>
>>>>>> cs.stax-api-1.0/${servicemix-specs-version}</bundle>    -
>>>>>>
>>>>
>>>>
>>>> <bundle>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.jax
>>>>>>
>>>>>>
>>>>>> b-impl/${jaxb-bundle-version}</bundle>
>>>>>> <bundle>mvn:org.apache.camel/camel-core/${pom.version}</bundle>
>>>>>>
>>>>
>>>>
>>>> <bundle>mvn:org.apache.camel.karaf/camel-karaf-commands/${pom.version}</bun
>>>>>>
>>>>>>
>>>>>> dle>    -</feature>
>>>>>> +§</feature>
>>>>>>    <feature name='camel-spring' version='${pom.version}'
>>>>>> resolver='(obr)'
>>>>>> start-level='50'>    <bundle
>>>>>>
>>>>
>>>>
>>>> dependency="true">mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/${ger
>>>>>>
>>>>>>
>>>>>> onimo-jta-spec-version}</bundle>    <feature
>>>>
>>>>
>>>> version="[3,4)">spring</feature>
>>>>>
>>>>>
>>>>> --
>>>>> Daniel Kulp
>>>>> dkulp@apache.org - http://dankulp.com/blog
>>>>> Talend Community Coder - http://coders.talend.com
>>>>>
>>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>
>>
>>
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Mime
View raw message