Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (athena.apache.org: domain of claus.ibsen@gmail.com
 designates 209.85.215.173 as permitted sender)
MIME-Version: 1.0
From: Claus Ibsen <claus.ibsen@gmail.com>
Date: Mon, 14 Nov 2011 13:10:12 +0100
Message-ID: 
 <CAGB5yNnQApcN3aVH4MTGCZNP-2SZ1yMgkFfTnOFrk-h-Pe0r+A@mail.gmail.com>
Subject: [DISCUSS] - Fix 2 pain issues with camel-bindy for Camel 2.9
To: dev <dev@camel.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

Hi

There are two pain issues I see we have with camel-bindy that I would
like to address. However as at least 1 of them is non backwards
compatible, we have previously targeted that for Camel 3.0. But that
was back in the start of the year when Camel 3.0 was more around the
corner.

Now that Camel 2.9 is a sort of big release I would suggest to move
the following two improvements forward to be fixed for Camel 2.9.0.

1)
The bindy data format, requires you to define a package name, where
bindy will then scan recursively in the package for any bindy model
classes (eg annotated with eg @CsvRecord etc.).

The problem is that this doesn't work well as you cannot have 2+ model
classes in the same package + sub packages.
As you cannot explicit define that you marshal to XXX class.

So I suggest to remove the package name, and mandate the end user to
specify a class type

For example to marshal to a Car class
.marshal().bindy(Car.class)

Then you can have 2+ model in the same package,
.marshal().bindy(Train.class)
.marshal().bindy(Plane.class)


2)
The output of the unmarshal operation is also confusing, as its a
List<Map<String, Object>>
The List is okay as that would be an entry for each entry. However the
Map represents a row.

So I suggest to make it simpler and what end users would expect
List<T>
Where T is the class type, such as List<Car>, List<Train> etc.

For example from an unit test where my T is WheatherModel I need this ugly code


  Map map = (Map)
mock.getReceivedExchanges().get(0).getIn().getBody(List.class).get(0);
        WeatherModel model = (WeatherModel) map.values().iterator().next();

        assertEquals(123, model.getId());
        assertEquals("Wednesday November 9 2011", model.getDate());
        assertEquals("Central California", model.getPlace());

Instead of just

  WeatherModel model = (WeatherModel)
mock.getReceivedExchanges().get(0).getIn().getBody(List.class).get(0);


We have a number of JIRA tickets and end users mailings on the @user
about issues with Bindy.
I think if we address these 1+2 here we solve the two major pain
points people have when getting started with Bindy.


-- 
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/