Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Tue, 4 Oct 2011 06:51:33 +0000 (UTC)
From: "Rich Newcomb (Updated) (JIRA)" <jira@apache.org>
To: dev@camel.apache.org
Message-ID: <58094921.6438.1317711093920.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1991275030.6176.1316779106096.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (CAMEL-4480) RuntimeCamelException "Ambiguous
 Parameter Mapping" must not be thrown, if there are parameters of the same
 type but with different QNames in ServiceInterfaceStrategy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/CAMEL-4480?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Newcomb updated CAMEL-4480:
--------------------------------

    Attachment: camel-4480-trunk.patch

The attached patch expands the multi-part unit test suite to demonstrates t=
he behavior described in this issue. =20

The patch also provides a potential fix for the issue.=20

Note that the solution recommended in the original issue description will n=
ot work. That solution would cause parameters that are reused across multip=
le web methods to be rejected with an error.  =20

An alternative solution (as implemented in the patch) is as follows:

1. Change the behavior of the ServiceInterfaceStrategy to log a WARN messag=
e in the case where a new QName mapping would override an existing  mapping=
.  The new mapping will be ignored after the warning.=20

2. Move the QName + dataType uniqueness enforcement to the @WebMethod level

The warning is an appropriate alternative to the current error. The Service=
InterfaceStrategy.findQNameForSoapActionOrType(=E2=80=A6) operation _could_=
 return an unexpected value when a dataType is reused within the interface =
with a different QName; however, this risk is fully mitigated when calling =
findQNameForSoapActionOrType(=E2=80=A6) with a valid soapAction that unique=
ly identifies the target @WebMethod on the service. At that point the Metho=
dInfo class is queried for the type-to-QName mapping for the method, and th=
e results will be as expected.
               =20
> RuntimeCamelException "Ambiguous Parameter Mapping" must not be thrown, i=
f there are parameters of the same type but with different QNames in Servic=
eInterfaceStrategy
> -------------------------------------------------------------------------=
---------------------------------------------------------------------------=
------------------
>
>                 Key: CAMEL-4480
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4480
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-soap
>    Affects Versions: 2.8.1
>            Reporter: Oliver Jelinski
>            Assignee: Rich Newcomb
>         Attachments: camel-4480-trunk.patch
>
>
> In different WebMethods I have parameters of the same type, but with diff=
erent QNames. The following if-clause (in ServiceInterfaceStrategy.analyzeS=
erviceInterface(..)) throws an exeption in these cases (thrown if NOT QName=
OfMethod1 equals QNameOfMethod2), but it should on the contrary throw an ex=
ception if the QNames ARE equal:
>                 if (inTypeNameToQName.containsKey(ti.getTypeName())
>                     && (!(ti.getTypeName().equals("javax.xml.ws.Holder"))=
)
>                     && (!(inTypeNameToQName.get(ti.getTypeName()).equals(=
ti.getElName())))) {
>                     throw new RuntimeCamelException("Ambiguous parameter =
mapping. The type [ "
>                                                     + ti.getTypeName()
>                                                     + " ] is already mapp=
ed to a QName in this context.");
>                 }
> The "NOT" must be deleted:
> ...
> && (inTypeNameToQName.get(ti.getTypeName()).equals(ti.getElName())))
> ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira