camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-4566) Create a camel component for Krati
Date Sat, 22 Oct 2011 15:01:32 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133411#comment-13133411
] 

Claus Ibsen commented on CAMEL-4566:
------------------------------------

Just a few observations. Didn't have time to review it all
- javadoc says HelloWorld
- LOG.error and then you continue. Should be LOG.warn instead. And a good idea is in the WARN
message to say that ". This exception is ignored." or something to indicate we continue
- In the consumer you override/copy code from camel-core, only do this if the code is to be
changed.
- Add code comment in onFailure that its on purpose its empty in the onCompletion you add
to the exchange
- You use a default of max message per poll of 10, the code you override does not indicate
this.

Okay gotta go
                
> Create a camel component for Krati
> ----------------------------------
>
>                 Key: CAMEL-4566
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4566
>             Project: Camel
>          Issue Type: New Feature
>            Reporter: Ioannis Canellos
>            Assignee: Ioannis Canellos
>         Attachments: CAMEL-4566-patch.txt
>
>
> Krati is a simple persistent data store with very low latency and high throughput.
> We could have a producer/consumer for krati key-value stores, an idepotent consumer and
as a persistence provider for other components (e.g. Hazelcast).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message