Return-Path: X-Original-To: apmail-camel-dev-archive@www.apache.org Delivered-To: apmail-camel-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69890729D for ; Wed, 28 Sep 2011 05:46:13 +0000 (UTC) Received: (qmail 59551 invoked by uid 500); 28 Sep 2011 05:46:12 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 58005 invoked by uid 500); 28 Sep 2011 05:46:10 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 57726 invoked by uid 99); 28 Sep 2011 05:46:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Sep 2011 05:46:07 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Sep 2011 05:46:06 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 0359F28C5BE for ; Wed, 28 Sep 2011 05:45:46 +0000 (UTC) Date: Wed, 28 Sep 2011 05:45:46 +0000 (UTC) From: =?utf-8?Q?Christian_M=C3=BCller_=28Assigned=29_=28JIRA=29?= To: dev@camel.apache.org Message-ID: <894926328.2584.1317188746015.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <179944146.2158.1317111373818.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Assigned] (CAMEL-4491) dataCoding not working properly in camel-smpp MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAMEL-4491?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian M=C3=BCller reassigned CAMEL-4491: --------------------------------------- Assignee: Christian M=C3=BCller =20 > dataCoding not working properly in camel-smpp > --------------------------------------------- > > Key: CAMEL-4491 > URL: https://issues.apache.org/jira/browse/CAMEL-4491 > Project: Camel > Issue Type: Bug > Components: camel-smpp > Affects Versions: 2.7.0, 2.8.0, 2.9.0 > Reporter: Jonas Bengtsson > Assignee: Christian M=C3=BCller > Attachments: patch.txt > > > This is related to CAMEL-3093. > The way the dataCoding option works is incorrect (or at least very confus= ing). After reading the documentation I was under the impression that the g= iven value would be used in the data_coding-part of the submit_sm PDU-packe= ts, but this is not the case. When 0 is given as dataCoding 0x11 (hexadecim= al) is sent in the PDU-packets. If 4 is specified 0x15 is sent, and if 8 is= specified then 0x19 is sent. This is caused in SmppProducer by the use of = the constructor with several parameters: > {code} > new GeneralDataCoding( > false, > true, > MessageClass.CLASS1, > Alphabet.valueOf(submitSm.getDataCoding())) > {code} > It constructs a DCS-value as defined in the GSM 03.38 specification, not = as specified in the SMPP specification. 0x11 is for example a valid DCS-val= ue in GSM 03.38, but is reserved in SMPP. I think that it would be better a= nd more logical if the constructor with one parameter was used instead: > {code} > new GeneralDataCoding(submitSm.getDataCoding()) > {code} > This is more flexibal (DCS-values can still be created manually) and is a= better default value (0 instead of 0x11). With my SMS-center (this probabl= y varies between centers though) a data_coding of 0x11 forces me to do the = 7-bit GSM decoding myself. When 0 is specified (or 3) all I have to do is t= o pass it ISO-8859-1 encoded bytes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira