Return-Path: X-Original-To: apmail-camel-dev-archive@www.apache.org Delivered-To: apmail-camel-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 30A8E7D02 for ; Thu, 15 Sep 2011 01:37:25 +0000 (UTC) Received: (qmail 3190 invoked by uid 500); 15 Sep 2011 01:37:25 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 3155 invoked by uid 500); 15 Sep 2011 01:37:25 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 3142 invoked by uid 99); 15 Sep 2011 01:37:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Sep 2011 01:37:25 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of hzbarcea@gmail.com designates 209.85.212.41 as permitted sender) Received: from [209.85.212.41] (HELO mail-vw0-f41.google.com) (209.85.212.41) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Sep 2011 01:37:15 +0000 Received: by vwm42 with SMTP id 42so3790801vwm.14 for ; Wed, 14 Sep 2011 18:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=ISJYA++RXOZy4+kjhunQgz4WFSJ6DQklr6/ZvoN1ENo=; b=fu/jouJ/DuI+loTyhoKQlvnpK4MyK9QaQsmVzuYsgMofMh7M7cn9A2lZpQHNKNyunV nDwUbYrlI4dOomluoeBs5NiOozocL3zBImymFOBSDNebglL3eg/SrGaDJptiEs5qsy5o TQ8TcdivAf8BgKoDSDypd8U9uyN2Lev0FZWVs= Received: by 10.220.108.16 with SMTP id d16mr119592vcp.261.1316050614272; Wed, 14 Sep 2011 18:36:54 -0700 (PDT) Received: from [10.40.58.206] (cpe-174-109-045-188.nc.res.rr.com. [174.109.45.188]) by mx.google.com with ESMTPS id a10sm4054514vdk.7.2011.09.14.18.36.52 (version=SSLv3 cipher=OTHER); Wed, 14 Sep 2011 18:36:53 -0700 (PDT) Message-ID: <4E7156B5.7010401@gmail.com> Date: Wed, 14 Sep 2011 21:36:53 -0400 From: Hadrian Zbarcea User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Thunderbird/3.1.13 MIME-Version: 1.0 To: dev@camel.apache.org Subject: Re: svn commit: r1170077 - in /camel/trunk: components/camel-jpa/pom.xml components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaConsumer.java parent/pom.xml platforms/karaf/features/src/main/resources/features.xml pom.xml References: <20110913081809.301E0238890A@eris.apache.org> <4E71562C.8040705@gmail.com> In-Reply-To: <4E71562C.8040705@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org https://builds.apache.org/job/Camel.trunk.fulltest/460/org.apache.camel$camel-jpa/testReport/ On 09/14/2011 09:34 PM, Hadrian Zbarcea wrote: > I believe this patch broke 4 tests in camel-jpa. See test results below: > > Tests in error: > > testSendTraceMessage(org.apache.camel.processor.interceptor.JpaTraceEventMessageTest): > Could not open JPA EntityManager for transaction; nested exception is > > org.apache.openjpa.persistence.ArgumentException: This configuration > disallows runtime optimization, but the following listed types were not > enhanced at build time or at class load time with a javaagent: " > > testFileConsumerJpaIdempotent(org.apache.camel.processor.jpa.FileConsumerJpaIdempotentTest): > Could not open JPA EntityManager for transaction; nested exception is > > org.apache.openjpa.persistence.ArgumentException: This configuration > disallows runtime optimization, but the following listed types were not > enhanced at build time or at class load time with a javaagent: " > > testDuplicateMessagesAreFilteredOut(org.apache.camel.processor.jpa.JpaIdempotentConsumerTest): > Could not open JPA EntityManager for transaction; nested exception is > > org.apache.openjpa.persistence.ArgumentException: This configuration > disallows runtime optimization, but the following listed types were not > enhanced at build time or at class load time with a javaagent: " > > testFailedExchangesNotAdded(org.apache.camel.processor.jpa.JpaIdempotentConsumerTest): > Could not open JPA EntityManager for transaction; nested exception is > > org.apache.openjpa.persistence.ArgumentException: This configuration > disallows runtime optimization, but the following listed types were not > enhanced at build time or at class load time with a javaagent: " > > Tests run: 42, Failures: 0, Errors: 4, Skipped: 0 > > > > Hadrian > > On 09/13/2011 04:18 AM, davsclaus@apache.org wrote: >> Author: davsclaus >> Date: Tue Sep 13 08:18:08 2011 >> New Revision: 1170077 >> >> URL: http://svn.apache.org/viewvc?rev=1170077&view=rev >> Log: >> CAMEL-3742: Upgraded camel-jpa to JPA2 spec. Thanks to Ioannis for the >> patch. >> >> Modified: >> camel/trunk/components/camel-jpa/pom.xml >> camel/trunk/components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaConsumer.java >> >> camel/trunk/parent/pom.xml >> camel/trunk/platforms/karaf/features/src/main/resources/features.xml >> camel/trunk/pom.xml >> >> Modified: camel/trunk/components/camel-jpa/pom.xml >> URL: >> http://svn.apache.org/viewvc/camel/trunk/components/camel-jpa/pom.xml?rev=1170077&r1=1170076&r2=1170077&view=diff >> >> ============================================================================== >> >> --- camel/trunk/components/camel-jpa/pom.xml (original) >> +++ camel/trunk/components/camel-jpa/pom.xml Tue Sep 13 08:18:08 2011 >> @@ -66,8 +66,8 @@ >> spring-orm >> >> >> -org.apache.servicemix.specs >> -org.apache.servicemix.specs.java-persistence-api-1.1.1 >> >> +org.apache.geronimo.specs >> +geronimo-jpa_2.0_spec >> provided >> >> >> @@ -103,50 +103,28 @@ >> >> >> >> - >> - >> - >> - >> - >> -org.apache.maven.plugins >> -maven-antrun-plugin >> - >> - >> -process-test-classes >> - >> - >> - >> - >> - >> - >> - >> -> classname="org.apache.openjpa.ant.PCEnhancerTask"> >> - >> - >> - >> - >> - >> - >> - >> - >> - >> -> name="org/apache/camel/processor/**/JpaTraceEventMessage.class" /> >> - >> -> propertiesFile="${basedir}/src/test/resources/META-INF/persistence.xml" /> >> >> - >> - >> - >> - >> - >> - >> - >> - >> -run >> - >> - >> - >> - >> - >> - >> - >> + >> + >> + >> + >> +org.codehaus.mojo >> +openjpa-maven-plugin >> +1.2 >> + >> +org/apache/camel/examples/*.class >> +true >> +true >> + >> + >> + >> +enhancer >> +process-test-classes >> + >> +test-enhance >> + >> + >> + >> + >> + >> + >> >> >> Modified: >> camel/trunk/components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaConsumer.java >> >> URL: >> http://svn.apache.org/viewvc/camel/trunk/components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaConsumer.java?rev=1170077&r1=1170076&r2=1170077&view=diff >> >> ============================================================================== >> >> --- >> camel/trunk/components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaConsumer.java >> (original) >> +++ >> camel/trunk/components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaConsumer.java >> Tue Sep 13 08:18:08 2011 >> @@ -273,6 +273,11 @@ public class JpaConsumer extends Schedul >> if (LOG.isDebugEnabled()) { >> LOG.debug("Failed to achieve lock on entity: " + entity + ". Reason: " >> + e, e); >> } >> + //TODO: Find if possible an alternative way to handle results of >> netive queries. >> + //Result of native queries are Arrays and cannot be locked by all >> JPA Providers. >> + if (entity.getClass().isArray()) { >> + return true; >> + } >> return false; >> } >> } >> >> Modified: camel/trunk/parent/pom.xml >> URL: >> http://svn.apache.org/viewvc/camel/trunk/parent/pom.xml?rev=1170077&r1=1170076&r2=1170077&view=diff >> >> ============================================================================== >> >> --- camel/trunk/parent/pom.xml (original) >> +++ camel/trunk/parent/pom.xml Tue Sep 13 08:18:08 2011 >> @@ -72,6 +72,7 @@ >> 1.1 >> >> 1.1.1 >> 1.1.1 >> +1.1 >> 1.0.1 >> 1.1.1 >> 1.1.1 >> @@ -1016,6 +1017,11 @@ >> ${geronimo-jpa-spec-version} >> >> >> +org.apache.geronimo.specs >> +geronimo-jpa_2.0_spec >> +${geronimo-jpa2-spec-version} >> + >> + >> org.apache.servicemix.specs >> org.apache.servicemix.specs.java-persistence-api-1.1.1 >> >> ${servicemix-specs-version} >> >> Modified: >> camel/trunk/platforms/karaf/features/src/main/resources/features.xml >> URL: >> http://svn.apache.org/viewvc/camel/trunk/platforms/karaf/features/src/main/resources/features.xml?rev=1170077&r1=1170076&r2=1170077&view=diff >> >> ============================================================================== >> >> --- >> camel/trunk/platforms/karaf/features/src/main/resources/features.xml >> (original) >> +++ >> camel/trunk/platforms/karaf/features/src/main/resources/features.xml >> Tue Sep 13 08:18:08 2011 >> @@ -371,7 +371,7 @@ >> mvn:org.apache.camel/camel-josql/${pom.version} >> >> > start-level='50'> >> -> dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.java-persistence-api-1.1.1/${servicemix-specs-version} >> >> +> dependency="true">mvn:org.apache.geronimo.specs/geronimo-jpa_2.0_spec/${geronimo-jpa2-spec-version} >> >> spring-tx >> > dependency="true">mvn:org.apache.geronimo.specs/geronimo-el_1.0_spec/${geronimo-el-version} >> >> > dependency="true">mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/${geronimo-jta-spec-version} >> >> @@ -383,7 +383,7 @@ >> > dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.ant/${ant-bundle-version} >> >> > dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.serp/${serp-bundle-version} >> >> > dependency="true">mvn:org.apache.geronimo.specs/geronimo-jms_1.1_spec/${geronimo-jms-spec-version} >> >> -mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.openjpa/${openjpa-bundle-version} >> >> +mvn:org.apache.openjpa/openjpa/${openjpa-version} >> spring-orm >> camel-core >> mvn:org.apache.camel/camel-jpa/${pom.version} >> >> Modified: camel/trunk/pom.xml >> URL: >> http://svn.apache.org/viewvc/camel/trunk/pom.xml?rev=1170077&r1=1170076&r2=1170077&view=diff >> >> ============================================================================== >> >> --- camel/trunk/pom.xml (original) >> +++ camel/trunk/pom.xml Tue Sep 13 08:18:08 2011 >> @@ -49,7 +49,7 @@ >> 2.1 >> 2.3.5 >> >> -1.2.2 >> +2.1.1 >> >> >> >> >>