Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Mon, 5 Sep 2011 13:44:16 +0000 (UTC)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: dev@camel.apache.org
Message-ID: 
 <2058497240.17191.1315230256422.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1629078622.16840.1315210750006.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Resolved] (CAMEL-4414) CamelLogger should not be a
 Processor and a log class at the same time and it should not have
 ServiceSupport
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CAMEL-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider resolved CAMEL-4414.
----------------------------------------

    Resolution: Fixed

> CamelLogger should not be a Processor and a log class at the same time and it should not have ServiceSupport
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4414
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4414
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>             Fix For: 2.9.0
>
>
> CamelLogger currently does too many things.
> 1. It is a log class that stores a log level and a slf4j logger. It suppports some methods for logging with the set level
> 2. It is a processor for logging exchanges
> 3. It extends ServiceSupport even though it has no services (is apparently needed fro ThroughputLogger
> So what I propose is:
> - Leave the current class as is but mark as @Deprecated
> - Introduce a new CamelLogger that only supports 1.
> - Introduce a CamelLogProcessor in processor that only supports 2.
> - Make ThroughputLogger not extend CamelLogger but instead delegate to the new CamelLogger

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira