Return-Path: X-Original-To: apmail-camel-dev-archive@www.apache.org Delivered-To: apmail-camel-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56CAE7DEF for ; Tue, 6 Sep 2011 14:44:35 +0000 (UTC) Received: (qmail 9175 invoked by uid 500); 6 Sep 2011 14:44:34 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 8600 invoked by uid 500); 6 Sep 2011 14:44:34 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 8395 invoked by uid 99); 6 Sep 2011 14:44:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2011 14:44:33 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL,WEIRD_PORT X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.85.173.253] (HELO server.dankulp.com) (64.85.173.253) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2011 14:44:27 +0000 Received: by server.dankulp.com (Postfix, from userid 5000) id 3393D183EF1; Tue, 6 Sep 2011 10:44:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on server.dankulp.com X-Spam-Level: X-Msg-File: /tmp/mailfilter-dev@camel.apache.org.QU1U0TWQXR Received: from dilbert.dankulp.com (c-24-91-72-253.hsd1.ma.comcast.net [24.91.72.253]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.dankulp.com (Postfix) with ESMTPSA id 9F8ED183EEB for ; Tue, 6 Sep 2011 10:44:05 -0400 (EDT) From: Daniel Kulp To: dev@camel.apache.org Subject: Re: svn commit: r1164338 - in /camel/trunk/components/camel-gae/src/test/java/org/apache/camel/component/gae: auth/GAuthEndpointTest.java http/GHttpBindingTest.java Date: Tue, 06 Sep 2011 10:44:04 -0400 Message-ID: <1511546.W90APKruQn@dilbert.dankulp.com> User-Agent: KMail/4.7.0 (Linux/3.0.1; KDE/4.7.0; x86_64; ; ) In-Reply-To: <20110902030628.D48662388A1C@eris.apache.org> References: <20110902030628.D48662388A1C@eris.apache.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-102.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.3.1 On Friday, September 02, 2011 3:06:28 AM hadrian@apache.org wrote: > Author: hadrian > Date: Fri Sep 2 03:06:28 2011 > New Revision: 1164338 > > URL: http://svn.apache.org/viewvc?rev=1164338&view=rev > Log: > More URI encoding fixes ........... > camel/trunk/components/camel-gae/src/test/java/org/apache/camel/component/g > ae/http/GHttpBindingTest.java (original) +++ > camel/trunk/components/camel-gae/src/test/java/org/apache/camel/component/g > ae/http/GHttpBindingTest.java Fri Sep 2 03:06:28 2011 @@ -103,7 +103,7 @@ > public class GHttpBindingTest { > assertEquals("http://custom.org:8080/path?a=b", > binding.getRequestUrl(endpoint, exchange).toString()); } > > - @Test > + // FIXME: URI encoding @Test > public void testGetRequestUrlEncoding() throws Exception { > GHttpEndpoint endpoint = > createEndpoint("ghttp://somewhere.com:9090/path?bridgeEndpoint=false&a=b > c"); assertEquals("http://somewhere.com:9090/path?a=b+c", > binding.getRequestUrl(endpoint, exchange).toString()); I would suggest using an @Ignore("FIXME: URI encoding") or similar for things like this in the future. It at least shows up in the test reports that a test was written, but not run. I hate it when I'm looking through code and see tests that have been completely commented out. The @Ignore at least makes finding them later easier. -- Daniel Kulp dkulp@apache.org http://dankulp.com/blog Talend - http://www.talend.com