camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CAMEL-4444) Wrong slash in FTP component for doneFile
Date Tue, 13 Sep 2011 11:36:09 GMT

     [ https://issues.apache.org/jira/browse/CAMEL-4444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Claus Ibsen resolved CAMEL-4444.
--------------------------------

    Resolution: Fixed

Thanks for the patch

> Wrong slash in FTP component for doneFile
> -----------------------------------------
>
>                 Key: CAMEL-4444
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4444
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-ftp
>    Affects Versions: 2.8.0
>            Reporter: Olivier Cheslet
>            Assignee: Claus Ibsen
>             Fix For: 2.8.2, 2.9.0
>
>         Attachments: CAMEL-4444.patch, CAMEL-4444.patch
>
>
> I tried to use the doneFile with FTP component.
> When I used it to my FTP on my windows machine everything goes fine.
> When I tried to act the same with a FTP host on a Linux machine, I got an issue.
> I sniff the packet to see what goes wrong and I see this :
> the doneFile 
> DELE public/Test/in\myFile.txt  
> the file to process
> DELE public/Test/in/myFile.xml
> After a Quick look on the code:
> org.apache.camel.component.file.GenericFileEndpoint 
> line 682
>  String answer = pattern;
>         if (ObjectHelper.isNotEmpty(path) && ObjectHelper.isNotEmpty(pattern))
{
>             // done file must always be in same directory as the real file name
>             answer = path + File.separator + pattern;
>         }
>         if (getConfiguration().needToNormalize()) {
>             // must normalize path to cater for Windows and other OS
>             answer = FileUtil.normalizePath(answer);
>         }
> We use the "File.Separator" but in this case, it should get a kind of "FTP.Separator"
or the FTP component should return true to the needToNormalize method and change the narmalizePath
method to manage this case.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message