camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-4475) Make API self contained
Date Thu, 22 Sep 2011 13:05:26 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112520#comment-13112520
] 

Claus Ibsen commented on CAMEL-4475:
------------------------------------

You cannot assume the XSD is not changed because tests passes. The XSD can very well change
as the elements not inherit new base types and whatnot. People have generated tooling and
whatnot with Camel, based upon the XSD types is kept stable.

API changes should be kept to minimum. There is no need to change the API in the model.
Inside the model, ProcessorDefinition makes sense to use. This has been the API since the
first commit from Camel. Respect this!

FromDefinition extends OptionalIdentifiedDefinition, which is not a ProcessorDefinition.




> Make API self contained
> -----------------------
>
>                 Key: CAMEL-4475
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4475
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>             Fix For: 2.9.0
>
>         Attachments: camel-4475-1.patch, camel-4475-2.patch, camel-4475-after.png, camel-4475-before.png
>
>
> The API, SPI packages of camel are already quite independent after the previous refactorings.
There are three classes in model that are still needed at the moment.
> ProcessorDefinition, RouteDefinition and FromDefiniton
> I propose to add the necessary methods to NamedNode to be able to reference most of the
functionality of the classes. For RouteDefinition I propose a special interface that adds
the ErrorHandler. For the rare cases where more functionality is needed a instanceof and a
cast can be used.
> I will attach a patch shortly that solves the issue and would be glad about some reviews.
> The patch can not be fully compatible but the changes are mostly in spi interfaces that
are probably rather rarely used.
> I will also add screenshots from structure 101 that show how much the architecture improves
after this patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message