Return-Path: 
 <dev-return-31032-apmail-camel-dev-archive=camel.apache.org@camel.apache.org>
X-Original-To: apmail-camel-dev-archive@www.apache.org
Delivered-To: apmail-camel-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5A6A566C1
	for <apmail-camel-dev-archive@www.apache.org>;
 Sat,  6 Aug 2011 20:27:49 +0000 (UTC)
Received: (qmail 30590 invoked by uid 500); 6 Aug 2011 20:27:49 -0000
Delivered-To: apmail-camel-dev-archive@camel.apache.org
Received: (qmail 30540 invoked by uid 500); 6 Aug 2011 20:27:49 -0000
Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@camel.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@camel.apache.org>
List-Post: <mailto:dev@camel.apache.org>
List-Id: <dev.camel.apache.org>
Reply-To: dev@camel.apache.org
Delivered-To: mailing list dev@camel.apache.org
Received: (qmail 30531 invoked by uid 99); 6 Aug 2011 20:27:49 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Aug 2011 20:27:49 +0000
X-ASF-Spam-Status: No, hits=-2000.7 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Aug 2011 20:27:47 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 3D643AF6C9
	for <dev@camel.apache.org>; Sat,  6 Aug 2011 20:27:27 +0000 (UTC)
Date: Sat, 6 Aug 2011 20:27:27 +0000 (UTC)
From: "surya (JIRA)" <jira@apache.org>
To: dev@camel.apache.org
Message-ID: 
 <1300037905.14085.1312662447247.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <829964079.13489.1312595008615.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (CAMEL-4311) Camel Bindy Parser One to Many KvP
 Unmarshall Issue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/CAMEL-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

surya updated CAMEL-4311:
-------------------------

    Attachment:     (was: BindyKeyValuePairFactory_patch_4311.txt)

> Camel Bindy Parser One to Many KvP Unmarshall Issue
> ---------------------------------------------------
>
>                 Key: CAMEL-4311
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4311
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.7.0, 2.7.2, 2.7.3, 2.8.0
>         Environment: Windows, Linux 
>            Reporter: surya
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: BindyComplexOneToManyKeyValuePairUnMarshallTest_patch_4311.txt, BindyKeyValuePairDataFormat_patch_4311.txt, BindyKeyValuePairFactory_patch_4311.txt
>
>
> Bindy KvP unmarshall issue. 
> While unmarshalling FIX messages, camel-bindy causing inconsistencies if the incoming fix messages are defined to map using 'OneToMany' annotations.
> In a given route for eg:
>  BindyKeyValuePairDataFormat kvpBindyDataFormat = new BindyKeyValuePairDataFormat("org.apache.camel.dataformat.bindy.model.fix.complex.onetomany");
>         public void configure() {
>             from(URI_DIRECT_START).unmarshal(kvpBindyDataFormat).to(URI_MOCK_RESULT);
>         }
> kvpBindyDataFormat is single instance for multiple threads and with in 'BindyKeyValuePairFactory' class instance varialbe  below is shared across multiple threads causing data inconsistencies.
> private Map<String, List<Object>> lists = new HashMap<String, List<Object>>(); 
> Values from previous thread/messages are retained in the current thread causing issues.
> For eg in the test case: public class BindyComplexOneToManyKeyValuePairUnMarshallTest extends CommonBindyTest 
> if we send another message  with no repeating groups are sent.
> String message2 = "8=FIX 4.19=2034=135=049=INVMGR56=BRKR" + "1=BE.CHM.00111=CHM0001-0158=this is a camel - bindy test" 
>         				  + "10=220";
> The output message has repeating group data from message processed in earlier thread are pouplated causing data inconsistencies.
> Please suggest the fix considering multi-threading scenario. I am willing to volunteer for the fix.
> Regards,
> Surya
>  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira