Return-Path: X-Original-To: apmail-camel-dev-archive@www.apache.org Delivered-To: apmail-camel-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 68AC06F35 for ; Fri, 8 Jul 2011 11:45:40 +0000 (UTC) Received: (qmail 90070 invoked by uid 500); 8 Jul 2011 11:45:40 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 89870 invoked by uid 500); 8 Jul 2011 11:45:37 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 89856 invoked by uid 99); 8 Jul 2011 11:45:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jul 2011 11:45:35 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.85.173.253] (HELO server.dankulp.com) (64.85.173.253) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jul 2011 11:45:27 +0000 Received: by server.dankulp.com (Postfix, from userid 5000) id 38611183BC9; Fri, 8 Jul 2011 07:45:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on server.dankulp.com X-Spam-Level: X-Msg-File: /tmp/mailfilter-dev@camel.apache.org.UOAMUtI1IB Received: from dilbert.dankulp.com (c-24-91-72-253.hsd1.ma.comcast.net [24.91.72.253]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.dankulp.com (Postfix) with ESMTPSA id 33310183BB7; Fri, 8 Jul 2011 07:45:05 -0400 (EDT) From: Daniel Kulp To: commits@camel.apache.org, dev@camel.apache.org Subject: Re: svn commit: r1144254 - /camel/trunk/platforms/karaf/features/src/main/resources/features.xml Date: Fri, 08 Jul 2011 07:45:04 -0400 Message-ID: <8456175.WL2YEicsgy@dilbert.dankulp.com> User-Agent: KMail/4.6.0 (Linux/2.6.39; KDE/4.6.4; x86_64; ; ) In-Reply-To: <20110708110945.715C223888FE@eris.apache.org> References: <20110708110945.715C223888FE@eris.apache.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-102.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.3.1 I'm -1 to this. commons-pool is already a bundle and thus all the other features should be updated to use it instead of the servicemix wrapper. In addition, if you install activemq or similar, you end up with commons-pool, not the servicemix version. Thus, I would say, update the others to use commons pool. The other reason I'm -1 on this...... CXF doesn't use commons-pool. There is no need to even have this in the cxf feature. It should be pulled in via spring-jms or activemq or similar. (Just noticed it is marked runtime scope on cxf-rt-transport-jms which is wrong. Should be test scope. I'll fix that.) Dan On Friday, July 08, 2011 11:09:45 AM ningjiang@apache.org wrote: > Author: ningjiang > Date: Fri Jul 8 11:09:45 2011 > New Revision: 1144254 > > URL: http://svn.apache.org/viewvc?rev=1144254&view=rev > Log: > CAMEL-4195 use servicemix commons-pool bundle in camel-cxf feature > > Modified: > camel/trunk/platforms/karaf/features/src/main/resources/features.xml > > Modified: > camel/trunk/platforms/karaf/features/src/main/resources/features.xml URL: > http://svn.apache.org/viewvc/camel/trunk/platforms/karaf/features/src/main/ > resources/features.xml?rev=1144254&r1=1144253&r2=1144254&view=diff > =========================================================================== > === --- camel/trunk/platforms/karaf/features/src/main/resources/features.xml > (original) +++ > camel/trunk/platforms/karaf/features/src/main/resources/features.xml Fri > Jul 8 11:09:45 2011 @@ -50,7 +50,7 @@ > > > start-level='50'> - dependency="true">mvn:commons-pool/commons-pool/${commons-pool-version} ndle> + dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.b > undles.commons-pool/${commons-pool-bundle-version} dependency="true">mvn:org.apache.geronimo.specs/geronimo-jms_1.1_spec/${ger > onimo-jms-spec-version} dependency="true">mvn:org.springframework/spring-jms/${spring-version} dle> > mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.asm > /${asm-bundle-version} -- Daniel Kulp dkulp@apache.org http://dankulp.com/blog Talend - http://www.talend.com