camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: svn commit: r1144254 - /camel/trunk/platforms/karaf/features/src/main/resources/features.xml
Date Fri, 08 Jul 2011 11:45:04 GMT

I'm -1 to this.

commons-pool is already a bundle and thus all the other features should be 
updated to use it instead of the servicemix wrapper.

In addition, if you install activemq or similar, you end up with commons-pool, 
not the servicemix version.   Thus, I would say, update the others to use 
commons pool.


The other reason I'm -1 on this......   CXF doesn't use commons-pool.   There 
is no need to even have this in the cxf feature.  It should be pulled in via 
spring-jms or activemq or similar.  

(Just noticed it is marked runtime scope on cxf-rt-transport-jms which is 
wrong.  Should be test scope.  I'll fix that.)


Dan



On Friday, July 08, 2011 11:09:45 AM ningjiang@apache.org wrote:
> Author: ningjiang
> Date: Fri Jul  8 11:09:45 2011
> New Revision: 1144254
> 
> URL: http://svn.apache.org/viewvc?rev=1144254&view=rev
> Log:
> CAMEL-4195 use servicemix commons-pool bundle in camel-cxf feature
> 
> Modified:
>     camel/trunk/platforms/karaf/features/src/main/resources/features.xml
> 
> Modified:
> camel/trunk/platforms/karaf/features/src/main/resources/features.xml URL:
> http://svn.apache.org/viewvc/camel/trunk/platforms/karaf/features/src/main/
> resources/features.xml?rev=1144254&r1=1144253&r2=1144254&view=diff
> ===========================================================================
> === --- camel/trunk/platforms/karaf/features/src/main/resources/features.xml
> (original) +++
> camel/trunk/platforms/karaf/features/src/main/resources/features.xml Fri
> Jul  8 11:09:45 2011 @@ -50,7 +50,7 @@
>    </feature>
> 
>    <feature name="cxf" version="${cxf-version}" resolver='(obr)'
> start-level='50'> -    <bundle
> dependency="true">mvn:commons-pool/commons-pool/${commons-pool-version}</bu
> ndle> +    <bundle
> dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.b
> undles.commons-pool/${commons-pool-bundle-version}</bundle> <bundle
> dependency="true">mvn:org.apache.geronimo.specs/geronimo-jms_1.1_spec/${ger
> onimo-jms-spec-version}</bundle> <bundle
> dependency="true">mvn:org.springframework/spring-jms/${spring-version}</bun
> dle>
> <bundle>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.asm
> /${asm-bundle-version}</bundle>
-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog
Talend - http://www.talend.com

Mime
View raw message