Return-Path: X-Original-To: apmail-camel-dev-archive@www.apache.org Delivered-To: apmail-camel-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 99EE56C4F for ; Sat, 18 Jun 2011 11:21:56 +0000 (UTC) Received: (qmail 40339 invoked by uid 500); 18 Jun 2011 11:21:55 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 40301 invoked by uid 500); 18 Jun 2011 11:21:55 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 40293 invoked by uid 99); 18 Jun 2011 11:21:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Jun 2011 11:21:55 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of claus.ibsen@gmail.com designates 209.85.210.45 as permitted sender) Received: from [209.85.210.45] (HELO mail-pz0-f45.google.com) (209.85.210.45) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Jun 2011 11:21:49 +0000 Received: by pzk30 with SMTP id 30so2822796pzk.32 for ; Sat, 18 Jun 2011 04:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type:content-transfer-encoding; bh=bRTN5qAcvLweCJVYHXI5Hl31eBeX2O1In1m5AbV8NB4=; b=mLAQ2RepOrgVfkzjDksZhTQ/JytsyP/4fHizfUtzhqDHqWEapZSB7jMC/N1l3dFQkB ImQYCqKH+hGFNLgYweHrZKNB6oV6ocnaxES0DAM/ftnPaVXlSVo3Qva2+JK8DgAw3Mln YPgUXte5/VdcSTzfBsGXFThF5DHx0xL6b91zo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=Dk3pY9RZaDqcVaqgxrzEn8xs5Gx7qsfzMxuJVm9P1mletwTJ0Wx6OhnT7Sw31Y1Kcb RnPPoiRJczRnG2neAupMc1NOqlCqo5wcxpeaKehT+arZKmlAYJ9x3DQ/nCxoOeS983K5 B8bjK2bQ9XvIVt7RHkT3DZ1rahhExGmhMjleE= Received: by 10.68.30.137 with SMTP id s9mr1365625pbh.146.1308396087060; Sat, 18 Jun 2011 04:21:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.43.69 with HTTP; Sat, 18 Jun 2011 04:21:07 -0700 (PDT) In-Reply-To: References: <4DFC6F58.5070606@nanthrax.net> From: Claus Ibsen Date: Sat, 18 Jun 2011 13:21:07 +0200 Message-ID: Subject: Re: [DISCUSS] - Include spring-expression.jar by default in camel-spring To: dev@camel.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Hi Okay since spring-expression is already included due transient deps by camel-context, then we should be all set. The problem was camel-spring-security component, that didnt exclude the spring-expression JAR and thus got the old 3.0.3 version included. So I have fixed that in the pom.xml in the camel-spring-security component. So we should all be okay now. On Sat, Jun 18, 2011 at 1:15 PM, Claus Ibsen wrote: > On Sat, Jun 18, 2011 at 11:43 AM, Richard Kettelerij > wrote: >> I guess this only concerned OSGi users? Since i've noticed that camel-co= re >> already has a transitive dependency on spring-expression: >> > > I guess its spring-context that deps on expression. > The spring jars in camel-core is in fact optional, they are only > needed if you need to use JMX. > > That said, we have on the roadmap to correct this, so you can use > camel-core with JMX without any spring JARs at all. > We will move the spring based JMX support into camel-spring (eg the > spring JMX @ annotations). But thats another story. > > > >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Building Camel :: Core 2.8-SNAPSHOT >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] >> [INFO] --- maven-dependency-plugin:2.1:tree (default-cli) @ camel-core -= -- >> [INFO] org.apache.camel:camel-core:bundle:2.8-SNAPSHOT >> [INFO] +- org.slf4j:slf4j-api:jar:1.6.1:compile >> [INFO] +- org.fusesource.commonman:commons-management:jar:1.0:compile >> [INFO] +- org.springframework:spring-context:jar:3.0.5.RELEASE:compile >> [INFO] | =A0+- org.springframework:spring-expression:jar:3.0.5.RELEASE:c= ompile >> [INFO] | =A0\- org.springframework:spring-asm:jar:3.0.5.RELEASE:compile >> [INFO] +- org.osgi:org.osgi.core:jar:4.1.0:provided >> [INFO] +- junit:junit:jar:4.8.1:test >> [INFO] +- org.slf4j:slf4j-log4j12:jar:1.6.1:test >> [INFO] +- log4j:log4j:jar:1.2.16:test >> [INFO] \- org.springframework:spring-aop:jar:3.0.5.RELEASE:test (scope n= ot >> updated to compile) >> [INFO] =A0 =A0+- aopalliance:aopalliance:jar:1.0:test >> [INFO] =A0 =A0+- org.springframework:spring-beans:jar:3.0.5.RELEASE:test >> [INFO] =A0 =A0\- org.springframework:spring-core:jar:3.0.5.RELEASE:test >> [INFO] =A0 =A0 =A0 \- commons-logging:commons-logging:jar:1.1.1:test >> >> Nevertheless +1 for including this explicitly. >> >> On Sat, Jun 18, 2011 at 11:26 AM, Jean-Baptiste Onofr=E9 wrote: >> >>> +1 >>> >>> it makes sense >>> >>> Regards >>> JB >>> >>> >>> On 06/18/2011 11:15 AM, Claus Ibsen wrote: >>> >>>> Hi >>>> >>>> I think we should include the spring-expression.jar in the >>>> camel-spring component. Its for the Spring Expression Language >>>> supported, which we provide out of the box now. >>>> >>>> We may need to either have that added as well in the Karaf spring >>>> feature, or add it to the camel-spring feature in the Camel kit >>>> Like we do for spring-tx >>>> >>>> >>>> =A0 >>>> =A0 =A0 mvn:org.**apache.geronimo.specs/** >>>> geronimo-jta_1.1_spec/1.1.1 >>>> =A0 =A0 spring >>>> =A0 =A0 spring-dm >>>> =A0 =A0 mvn:org.**springframework/spring-t= x/3.0.** >>>> 5.RELEASE >>>> =A0 =A0 camel-**core >>>> =A0 =A0 mvn:org.apache.camel/**camel-spring/2.8-SNAPSHOT >>>> =A0 >>>> >>>> I noticed in the camel-spring-security component, that you out of the >>>> box would end up picking older releases of spring-expression as >>>> spring-security uses 3.0.3 >>>> [INFO] ------------------------------**------------------------------*= * >>>> ------------ >>>> [INFO] Building Camel :: Spring Security 2.8-SNAPSHOT >>>> [INFO] ------------------------------**------------------------------*= * >>>> ------------ >>>> [INFO] >>>> [INFO] --- maven-dependency-plugin:2.1:**tree (default-cli) @ >>>> camel-spring-security --- >>>> [INFO] org.apache.camel:camel-spring-**security:bundle:2.8-SNAPSHOT >>>> [INFO] +- org.apache.camel:camel-core:**jar:2.8-SNAPSHOT:compile >>>> [INFO] | =A0+- org.slf4j:slf4j-api:jar:1.6.1:**compile >>>> [INFO] | =A0\- org.fusesource.commonman:**commons-management:jar:1.0:*= * >>>> compile >>>> [INFO] +- org.apache.camel:camel-spring:**jar:2.8-SNAPSHOT:compile >>>> [INFO] | =A0+- org.springframework:spring-**context:jar:3.0.5.RELEASE:= ** >>>> compile >>>> [INFO] | =A0| =A0+- org.springframework:spring-**beans:jar:3.0.5.RELEA= SE:** >>>> compile >>>> [INFO] | =A0| =A0+- org.springframework:spring-** >>>> core:jar:3.0.5.RELEASE:compile >>>> [INFO] | =A0| =A0| =A0\- commons-logging:commons-**logging:jar:1.1.1:c= ompile >>>> [INFO] | =A0| =A0\- org.springframework:spring-** >>>> asm:jar:3.0.5.RELEASE:compile >>>> [INFO] | =A0+- org.springframework:spring-**aop:jar:3.0.5.RELEASE:comp= ile >>>> [INFO] | =A0| =A0\- aopalliance:aopalliance:jar:1.**0:compile >>>> [INFO] | =A0\- org.springframework:spring-tx:**jar:3.0.5.RELEASE:compi= le >>>> [INFO] +- org.springframework.security:**spring-security-core:jar:3.0.= ** >>>> 5.RELEASE:compile >>>> [INFO] | =A0+- org.springframework:spring-**expression:jar:3.0.3.RELEA= SE:** >>>> compile >>>> [INFO] | =A0+- org.aspectj:aspectjrt:jar:1.6.**8:compile >>>> [INFO] | =A0\- org.aspectj:aspectjweaver:jar:**1.6.8:compile >>>> [INFO] +- org.springframework.security:**spring-security-config:jar:3.= ** >>>> 0.5.RELEASE:compile >>>> [INFO] +- org.apache.camel:camel-test:**jar:2.8-SNAPSHOT:test >>>> [INFO] +- junit:junit:jar:4.8.1:test >>>> [INFO] +- org.slf4j:slf4j-log4j12:jar:1.**6.1:test >>>> [INFO] \- log4j:log4j:jar:1.2.16:test >>>> >>>> >>>> So by including spring-expression in camel-spring we ought to help >>>> align the spring version used out of the box. >>>> >>>> Any problems with this, I wonder? >>>> >>>> >>>> >>>> >> > > > > -- > Claus Ibsen > ----------------- > FuseSource > Email: cibsen@fusesource.com > Web: http://fusesource.com > Twitter: davsclaus, fusenews > Blog: http://davsclaus.blogspot.com/ > Author of Camel in Action: http://www.manning.com/ibsen/ > --=20 Claus Ibsen ----------------- FuseSource Email: cibsen@fusesource.com Web: http://fusesource.com Twitter: davsclaus, fusenews Blog: http://davsclaus.blogspot.com/ Author of Camel in Action: http://www.manning.com/ibsen/