camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: source distributions....
Date Thu, 23 Jun 2011 02:45:40 GMT
On Wednesday, June 22, 2011 5:38:19 PM Donald Whytock wrote:
> I actually use the source distribution for Windows, because opening up
> a .zip is one less step.  But I'm good either way.  Eclipse can deal
> with either file type.
> 

I attached a patch to:
https://issues.apache.org/jira/browse/CAMEL-4141

that currently keeps the .zip, just without the CR/LF filtering.  On my 
machine, that drops the builds to 1m2s from 2m28s.    If I turn off the zip, 
it drops a bit more to 48s.   Without the filtering, the incremental cost of 
the zip is 14s.   With filtering, it's WAY more.   If you want to give that a 
try, feel free to grab it while we continue discussing.  :-)

Dan


> Don
> 
> On Wed, Jun 22, 2011 at 5:13 PM, Aki Yoshida <elakito@googlemail.com> wrote:
> > I agree with you and I am also for a single unix-type source assembly.
> > 
> > saving energy and resources.
> > 
> > regards, aki
> > 
> > 2011/6/22 Daniel Kulp <dkulp@apache.org>:
> >> Question:
> >> 
> >> Does anyone really feel strongly that we need separate windows and
> >> unix SOURCE distributions?  We can easily chop a minute or two off
> >> the assembly build  if we only have a single source distribution.
> >>  Most of the time is spent doing the scans and the line ending
> >> filtering for the two separate source distribution assemblies.
> >> 
> >> I would propose that we drop to just a single source distro assembly.
> >> Reasons:
> >> 
> >> 1) Faster for us. :-)
> >> 
> >> 2) I'm going to doubt many people even use the source distributions.
> >> Gotta love Java and Maven.  :-)
> >> 
> >> 3) Windows does a good job handling the unix style endings now.  
> >>  Really, if you're using git on Windows to clone the camel repo, your
> >> getting it with unix endings anyway.  Has anyone even noticed?  (git
> >> doesn't have an eol-style and thus the repo that is created on unix
> >> would have the unix style)
> >> 
> >> 4) Other projects haven't had an issue.  For example, CXF has just a
> >> single "src" assembly (no filtering) and hasn't had an issue.  It
> >> produces both zip and tar/gz, but the contents are exactly the same.
> >>   (CXF also only has a single binary distro assembly, contents
> >> exactly the same)
> >> 
> >> 5) Technically, the "source" distribution should be an exact copy of
> >> the tag of the source that was used to build the release.   The
> >> filtering that is done really makes it not an exact copy.
> >> 
> >> 
> >> On my machine, a simple test shows that "mvn install" in the
> >> apache-camel directory drops from 2m28s down to 1m2s  with this type
> >> of change.
> >> 
> >> Anyway, I'm just throwing out an idea.   I'm kind of sick of sitting
> >> and
> >> watching it build assemblies.   :-)
> >> 
> >> 
> >> --
> >> Daniel Kulp
> >> dkulp@apache.org
> >> http://dankulp.com/blog
> >> Talend - http://www.talend.com
-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog
Talend - http://www.talend.com

Mime
View raw message