Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Tue, 5 Apr 2011 03:30:05 +0000 (UTC)
From: "Hadrian Zbarcea (JIRA)" <jira@apache.org>
To: dev@camel.apache.org
Message-ID: 
 <744196413.34101.1301974205929.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <834256760.14040.1299868439401.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CAMEL-3781) Add option to disable expiration on
 JMS component
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015738#comment-13015738 ] 

Hadrian Zbarcea commented on CAMEL-3781:
----------------------------------------

Heath, I am not disagreeing with you. I was just pointing out that there is another 2 line change that has exactly the same same effect. 

>From your example, if the requestTimeout=2000 and disableExpiration=true, then the value of requestTimeout is ignored, so one might as well set it to 0, it won't do any good to "want a timeout of some value". In other words a requestTimeout=0 would have the same semantics as disableExpiration=true, i.e. TTL not be set (unless I am missing something).

Do you agree with the assessment above? Introducing new options complicates urls, documentation, etc. and I prefer avoiding that when possible. Other than that the patch is good, thanks for the patch by the way. I would only recommend implementing it by using the value '0' of the requestTimeout (unused now) instead of introducing a new option.

> Add option to disable expiration on JMS component
> -------------------------------------------------
>
>                 Key: CAMEL-3781
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3781
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-jms
>    Affects Versions: 2.6.0
>         Environment: Java 1.6.0_24, Mac OS X 10.6.6
>            Reporter: Bryan Keller
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira