camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadrian Zbarcea (JIRA)" <>
Subject [jira] [Commented] (CAMEL-3781) Add option to disable expiration on JMS component
Date Tue, 05 Apr 2011 03:30:05 GMT


Hadrian Zbarcea commented on CAMEL-3781:

Heath, I am not disagreeing with you. I was just pointing out that there is another 2 line
change that has exactly the same same effect. 

>From your example, if the requestTimeout=2000 and disableExpiration=true, then the value
of requestTimeout is ignored, so one might as well set it to 0, it won't do any good to "want
a timeout of some value". In other words a requestTimeout=0 would have the same semantics
as disableExpiration=true, i.e. TTL not be set (unless I am missing something).

Do you agree with the assessment above? Introducing new options complicates urls, documentation,
etc. and I prefer avoiding that when possible. Other than that the patch is good, thanks for
the patch by the way. I would only recommend implementing it by using the value '0' of the
requestTimeout (unused now) instead of introducing a new option.

> Add option to disable expiration on JMS component
> -------------------------------------------------
>                 Key: CAMEL-3781
>                 URL:
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-jms
>    Affects Versions: 2.6.0
>         Environment: Java 1.6.0_24, Mac OS X 10.6.6
>            Reporter: Bryan Keller
>            Priority: Minor
>             Fix For: 2.8.0
>         Attachments: patch-3781.diff
> It would be nice to add an option to the JMS component to disable the use of message
expirations for InOut exchanges. If a client and server have clocks that are out-of-sync,
using message expiration can cause problems. More details can be found here:

This message is automatically generated by JIRA.
For more information on JIRA, see:

View raw message